fix: resolve N+1 query problem nos resolvers GraphQL#410
Open
DenisCDev wants to merge 1 commit into
Open
Conversation
Os resolvers de Card.expertises e Card.collaborations estavam chamando guidesRepository().getAll() pra cada card retornado. Com 50 cards, eram 100+ chamadas ao repositório por request. Solução: - Adicionado DataLoader pra fazer batch loading - Criado contexto GraphQL com loaders por request - Refatorado resolvers pra usar os loaders - Adicionado TTL no cache do storage (5min) Agora uma query com 50 cards faz apenas 1 chamada ao repositório em vez de 100+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
Os resolvers
Card.expertiseseCard.collaborationsestavam chamandoguidesRepository().getAll()pra cada card retornado na query. Isso causava um problema clássico de N+1:Solução
Implementei DataLoader pra fazer batch loading e resolver o problema:
_api/infra/dataloaders/com loaders pra guides e cardsTestes