[Proof of concept] derive specs system#499
Closed
azriel91 wants to merge 2 commits intoamethyst:masterfrom
Closed
Conversation
Member
Author
azriel91
commented
Oct 24, 2018
| Type::Path(TypePath { | ||
| path: | ||
| Path { | ||
| ref mut segments, .. |
Member
Author
There was a problem hiding this comment.
From Rust #beginners:
dyn r#CryZe:
ref is pseudo deprecated
use default match bindings instead
match &mut ty
ᚮscottmcmᚭ:
and +1 to
let segments = match &mut ty { Type::Path(TypePath { path: Path { segments, .. // <-- no more silliness },
torkleyy
reviewed
Oct 27, 2018
Member
torkleyy
left a comment
There was a problem hiding this comment.
This should be moved to shred.
Member
|
Closing since it's outside of Specs' scope and belongs to shred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to the RFC in issue #498. This allows you to do this:
and running this gives:
This change is