Skip to content

fixes UCIS schema compatibility#25

Open
eyck wants to merge 6 commits into
amiq-consulting:masterfrom
Minres:master
Open

fixes UCIS schema compatibility#25
eyck wants to merge 6 commits into
amiq-consulting:masterfrom
Minres:master

Conversation

@eyck

@eyck eyck commented Jun 18, 2022

Copy link
Copy Markdown

When using the generated XML with pyucis the reading fails as pyucis does a XSD schema validation using the XSD schema of the 'Unified Coverage Interoperability Standard (UCIS) Version 1.0'.
This pull request provides fixes to make the XML schema compliant.

@eyck

eyck commented Jun 21, 2022

Copy link
Copy Markdown
Author

This PR additionally addresses 2 things:

  • it improves on UCIS XML schema compatibility to add proper keys to all elements.
  • the cross report wrong coverage in get_inst_coverage() if some cross points are not hit. Therfore all bins are initialized in upon construction

@edcote

edcote commented Oct 5, 2022

Copy link
Copy Markdown

Do unit tests under test/ need to be updated for this change?

@eyck

eyck commented Oct 6, 2022

Copy link
Copy Markdown
Author

No, they pass with the changes of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants