Add WinZip AES encryption support#32
Merged
Merged
Conversation
Owner
Traditional encryption is deprecated, and I added it only because we had an old workflow that used traditional passwords. I would love to have proper encryption support.
Please feel free to add 7z cli dependency on CI |
fishtreesugar
force-pushed
the
winzip-aes
branch
from
7d24e2e to
db3a0a0
Compare
fishtreesugar
force-pushed
the
winzip-aes
branch
from
db3a0a0 to
e3dc9e5
Compare
Contributor
Author
|
@ananthakumaran Please let me know if you have any more comments. |
Owner
ananthakumaran
left a comment
ananthakumaran
left a comment
There was a problem hiding this comment.
left a few nitpicks, otherwise the changes lgtm
Contributor
Author
|
@ananthakumaran Done. I look forward to seeing the new release after it is merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an initial implementation of WinZip-style AES encryption (spec here: https://www.winzip.com/en/support/aes-encryption). I’ve only done quick manual tests so far—macOS Archive Utility and the 7z CLI—because our current test tools don’t understand the WinZip AES extras yet.
If the maintainers are on board with this feature, I’d love any ideas for beefing up the test coverage.