Removed geom_dotplot and replace with error#311
Merged
Conversation
tdhock
requested changes
Mar 10, 2026
Contributor
Author
|
@tdhock I have done all the changes that were required. Please tell if any further changes are to be implemented. |
tdhock
reviewed
May 7, 2026
tdhock
reviewed
May 7, 2026
tdhock
reviewed
May 7, 2026
Contributor
Author
|
@tdhock I believe the previously requested changes have been addressed and the related review comments are now outdated. Please let me know if there are any remaining modifications needed from my side. |
Collaborator
|
great, thanks! can you please add yourself as contributor in DESCRIPTION? |
Collaborator
|
Also, I invited you to the animint developers team. Can you please accept the invite? Can you please send future PRs from a new branch in this repo? (instead of your fork) |
Contributor
Author
|
Thanks! I have added myself as a contributor in the DESCRIPTION file and accepted the developers team invite. I will use branches from the main repo for future PRs instead of my fork. |
tdhock
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289
Following @tdhock's suggestion, this PR removes
geom_dotplot()and replaces it with a hard error directing users to
geom_point().Changes
geom_dotplot()now callsstop()immediatelyTesting
All tests pass:
@tdhock please review and suggest