Skip to content

Conversation

@criticalAY
Copy link
Contributor

@criticalAY criticalAY commented Dec 23, 2025

Purpose / Description

The code was duplicated so here I am modernizing AudioRecorder(picking best of both) and remove duplicate implementations

  • Consolidation of duplicate AudioRecorder classes into a single robust AudioRecorder class
  • Added support for AAC (High Quality) with a fallback to AMR_NB (Standard Quality).
  • Implemented Closeable for automatic resource management.

Fixes

NA

Approach

Remove dupicate code and create a new class

How Has This Been Tested?

Unit tests and manually on google pixel 10:

Screen_recording_20251223_152315.mp4

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY
Copy link
Contributor Author

criticalAY commented Dec 23, 2025

Something is wrong with git or maybe I messed up idk the test is not there :(

Sorry about the multiple force pushes files went missing

@criticalAY criticalAY force-pushed the refactor/common-ar branch 3 times, most recently from 29c4998 to 361a058 Compare December 23, 2025 08:34
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please send a video showing how you manually tested it.

You haven't described at all how you've done it.

@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Dec 23, 2025
@criticalAY criticalAY force-pushed the refactor/common-ar branch 2 times, most recently from 1dc2ba8 to 5487018 Compare December 23, 2025 09:19
@criticalAY criticalAY added Needs Author Reply Waiting for a reply from the original author and removed Needs Author Reply Waiting for a reply from the original author labels Dec 23, 2025
@criticalAY
Copy link
Contributor Author

  • resolved all comments
  • attached testing screen recording

@criticalAY criticalAY added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Dec 23, 2025
@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author and removed Needs Author Reply Waiting for a reply from the original author labels Dec 24, 2025
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Dec 29, 2025
- Consolidation of duplicate AudioRecorder classes into a single one
- Added support for AAC (High Quality) with a fallback to AMR_NB (Standard Quality).
- update Audio recorder usage in Audio controller and reviewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Second Approval Has one approval, one more approval to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants