Skip to content

Conversation

@BrayanDSO
Copy link
Member

by using savedStateHandle for persisting the current counts

refactors:

  • encapsulated the counts into a custom view (StudyCountsView)
  • added a new StudyCounts class

tests:

  • added tests for StudyCountsView

How Has This Been Tested?

Emulator 36

  1. Enable Don't keep activities
  2. Open the reviewer
  3. Put the app in the background
  4. Open the app again
  5. Check if the counts numbers persist
Counts on some scenarios Screenshot_20251227_134603 Cou Screenshot_20251227_135410 Screenshot_20251227_135424 Screenshot_20251227_140509 Screenshot_20251227_140526

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
Copy link
Member

@BrayanDSO I'd like this in 2.23.X, but it feels a little too involved

Any chance you'd disagree?

@BrayanDSO
Copy link
Member Author

BrayanDSO commented Dec 27, 2025

Splitting the 'fix' part isn't hard. I'll make a separate PR for that → #19946

@BrayanDSO BrayanDSO marked this pull request as draft December 27, 2025 17:32
@BrayanDSO BrayanDSO added the Blocked by dependency Currently blocked by some other dependent / related change label Dec 27, 2025
@BrayanDSO BrayanDSO changed the title fix(study-screen): counts reset on process death refactor(study-screen): encapsulate counts into a class Dec 27, 2025
@BrayanDSO BrayanDSO removed Blocked by dependency Currently blocked by some other dependent / related change Has Conflicts labels Dec 29, 2025
@BrayanDSO BrayanDSO marked this pull request as ready for review December 29, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants