refactor+test: Auto advance #19949
Open
refactor+test: Auto advance #19949
+315
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed in a500fe1 when Arthur tried to join the old and new study screen enums Adding it back it's necessary because I need it to be inside the `autoadvance` package so it can implement a sealed interface since the old study screen will be eventually gone, duplicating the class again seemed like the fastest approach.
BrayanDSO
force-pushed
the
test/auto-advance
branch
3 times, most recently
from
a5614da to
0821d4c
Compare
david-allison
approved these changes
Dec 28, 2025
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/autoadvance/AutoAdvance.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/autoadvance/AutoAdvance.kt
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/autoadvance/AutoAdvance.kt
Show resolved
Hide resolved
david-allison
requested changes
Dec 28, 2025
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
Whoops: this is a request for a few comment in the review/commits
david-allison
added
the
Needs Author Reply
that makes easier to test the class
BrayanDSO
force-pushed
the
test/auto-advance
branch
from
0821d4c to
0f99f86
Compare
BrayanDSO
removed
the
Needs Author Reply
david-allison
approved these changes
Dec 28, 2025
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
Cheers, nothing blocking
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2025 Hari Srinivasan <harisrini21@gmail.com> | |||
| * Copyright (c) 2024 Brayan Oliveira <brayandso.dev@gmail.com> | |||
Member
There was a problem hiding this comment.
Your call on 24/25, I believe you also moved to: <69634269+brayandso@users.noreply.github.com> in newer commits
| import kotlinx.coroutines.CompletableDeferred | ||
| import kotlinx.coroutines.test.StandardTestDispatcher | ||
| import kotlinx.coroutines.test.TestScope | ||
| import kotlinx.coroutines.test.advanceTimeBy |
Member
There was a problem hiding this comment.
advanceTimeBy has an override which accepts a Duration
david-allison
added
Needs Second Approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Approach
In the commits
How Has This Been Tested?
Emulator 31
Screen_recording_20251227_162711.mp4
Checklist
Please, go through these checks before submitting the PR.