Skip to content

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Dec 28, 2025

Purpose / Description

The names have been non-idiomatic for a while (originally written in Java in 2021)

Approach

  • rename file and remove object BundleUtils
  • rename methods to make them more discoverable in Kotlin
  • fix docs

How Has This Been Tested?

⚠️ Trusting CI

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

And move methods to top level (removing `object BundleUtils`)

Legacy code from Java
This was legacy code from Java

Use more idiomatic Kotlin names
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikehardy mikehardy added this pull request to the merge queue Jan 6, 2026
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jan 6, 2026
Merged via the queue into ankidroid:main with commit 3adc8d2 Jan 6, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 6, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 6, 2026
@david-allison david-allison deleted the bundle-refactor branch January 6, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants