Skip to content

Conversation

@Rv607x
Copy link

@Rv607x Rv607x commented Dec 28, 2025

Purpose / Description

This is a fix to handle animation settings read failure. The current implementation dint not handle failed reads properly, the fix adds handling of the read failure with appropriate error message

Fixes

fix: log and safely handle animation settings read failure

Approach

adds the correct error message when read settings fail. using Timber to log the message. Timber.w(e, "Failed to read system animation settings")

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Change is good.

Please fill out all the PR template

As it's a small change, it's fine to say it's untested, but we should know

Remove "learning" if it's not relevant (it's not)

The first 3 checkboxes should be considered

Use code fences or backticks when referencing code:

Timber.w(e, "message")

Or as a code fence (syntax highlighting):

Timber.w(e, "message")

The PR template specifically has * Fixes #Issue listed

This syntax does two things:

  • * produces a dynamic link with a preview when a PR or issue is linked
  • Fixes #issue closes the issue when the PR is merged

You want the link preview, but you don't want to close the issue, so use:

* Related to #13282 produces:

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author Reply Waiting for a reply from the original author New contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants