Skip to content

Conversation

@aladdin-afk
Copy link
Contributor

@aladdin-afk aladdin-afk commented Dec 28, 2025

Purpose / Description

Automated adding the Needs Review label to new opened, nondraft prs. This removes the need for maintainers to be pinged or check manually.

Fixes

Approach

Added a new job that uses github script to automatically add the Needs Review label when a new pr is opened or is not a draft.

How Has This Been Tested?

Verified the workflow logic in YAML file.
Confirmed the job only triggers for newly opened, undrafted prs

Learning (optional, can help others)

referenced GitHub Actions documentation for workflow conditions.
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax
https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️⚠️ This is a security-critical action (pull_request_target) and bugs here can cause catastrophic damage to the repo.

Please rebase this so there is only 1 commit, and that the commit only contains necessary changes.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Dec 28, 2025
@david-allison
Copy link
Member

Learning (optional, can help others)

referenced GitHub Actions documentation for workflow conditions.

Please list the docs

@aladdin-afk aladdin-afk force-pushed the ci/auto-needs-review-label branch from 56fe8ed to 6e13d37 Compare December 29, 2025 09:55
@criticalAY criticalAY added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Dec 29, 2025
@BrayanDSO

This comment was marked as outdated.

@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Jan 3, 2026
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How Has This Been Tested?
Verified the workflow logic in YAML file.
Confirmed the job only triggers for newly opened, undrafted prs

Please try the workflow on your fork, then report back the results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author Reply Waiting for a reply from the original author Needs Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Add 'Needs Review' label to opened PRs

4 participants