Skip to content

Fix: Android Studio warning #19969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
harshsomankar123-tech wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: Android Studio warning #19969

harshsomankar123-tech wants to merge 3 commits into from
+0 −4

Conversation

@harshsomankar123-tech
Copy link

@harshsomankar123-tech harshsomankar123-tech commented Dec 29, 2025 •
edited by lukstbit
Loading

Purpose / Description

Fix: android studio warning

Fixes

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@welcome
Copy link

welcome bot commented Dec 29, 2025

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

@ShaanNarendran
Copy link
Contributor

ShaanNarendran commented Dec 29, 2025

You should clean up your commits, you only want the commit that shows the changes you made

@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge squash-merge A squash & force push is required. The PR author may do this to speed up the merge process. labels Jan 2, 2026
lukstbit
lukstbit requested changes Jan 2, 2026
View reviewed changes
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, left one issue to fix.

Also please rebase your code on top of main instead of adding merge commits. Those commits shouldn't be present in your PR.

AnkiDroid/src/main/java/com/ichi2/anki/FieldEditLine.kt
val lastViewInTabOrder: View
get() = binding.expandButton

fun loadState(state: AbsSavedState) {
Copy link
Member

@lukstbit lukstbit Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting this method there's an unused import for AbsSavedState that should also be deleted.

@lukstbit lukstbit removed the Needs Second Approval Has one approval, one more approval to merge label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukstbit lukstbit lukstbit requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Needs Author Reply Waiting for a reply from the original author Priority-Low squash-merge A squash & force push is required. The PR author may do this to speed up the merge process.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshsomankar123-tech @ShaanNarendran @lukstbit @BrayanDSO