Feat (Progress Dialog): Compat to add new progress bar #19970
+221
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaanNarendran
force-pushed
the
Progress-Bar
branch
3 times, most recently
from
9ac8ea1 to
f94dfb1
Compare
sanjaysargam
suggested changes
Dec 29, 2025
| } | ||
| } | ||
|
|
||
| fun setMax(max: Int) = runOnUi { setMaxInternal(max) } |
| circularIndicator?.max = max | ||
| } | ||
|
|
||
| fun setProgress(value: Int) = runOnUi { setProgressInternal(value) } |
| } | ||
| } | ||
|
|
||
| fun incrementProgressBy(diff: Int) = runOnUi { setProgressInternal(progress + diff) } |
|
|
||
| fun incrementProgressBy(diff: Int) = runOnUi { setProgressInternal(progress + diff) } | ||
|
|
||
| var isIndeterminate: Boolean |
| } | ||
| } | ||
|
|
||
| private fun dismissDialogIfShowing(dialog: Dialog) { |
Contributor
Author
There was a problem hiding this comment.
The reason there's so many unused functions and variables is because I wanted it to be very similar to progressdialog since it is a compat wrapper. I thought this was best practice but if it's better to remove all the unused parts, I can
ShaanNarendran
force-pushed
the
Progress-Bar
branch
from
f94dfb1 to
5900d22
Compare
Contributor
Author
|
I implemented the changes which David had mentioned starting here: I'm not sure if I understood it in the right way, so if I'm wrong do let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This changes the UI of existing progress dialogs (deprecated in api 26) to newer material ui progress circles.
Fixes
Approach
Created a new compat class ProgressCompat.kt to easily change all the existing progressdialogs to the new ones. We use this class in CoroutineHelpers.kt to change all the withProgress dialogs. The compat class uses regex to check for values like x/y and updates the dialog with a progress circle (defined in a new xml) automatically, if not we use an indeterminate spinner.
How Has This Been Tested?
Screen_recording_20251229_200048.webm
I struggled to test this normally, using one-way sync was the best way I found. If anyone has larger decks, or a better place to test, please let me know.
Learning (optional, can help others)
Referred:
https://developer.android.com/reference/android/app/ProgressDialog
ActionProviderCompat.kt for documentation help
https://m2.material.io/components/progress-indicators/android#circular-progress-indicators : for design (not sure if we want to use m3 since I believe it was still under discussion in the discord)
Checklist
Please, go through these checks before submitting the PR.