refactor(whiteboard): extract toolbar into a separate view #19979
+358
−295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is less discoverable, but the `Add` button isn't a frequent action, so it's better to avoid occupying screen space if the user doesn't have many brushes.
Also 1. made `fragment_whiteboard` a FrameLayout, so changing the toolbar position is wayyyyyyyyyy easier with layout gravity 2. Used a `RecyclerView` instead of separate Horizontal and Vertical scrollViews, which should be more performant
BrayanDSO
added
Needs Review
Blocked by dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
On top of/Blocked by #19978
The whiteboard was so complex and big that I didn't make the best choices for part of its code design. So now, with a fresher mind, I'm trying to make it more pleasant to work with.
How Has This Been Tested?
Screen_recording_20251230_053103.mp4
Checklist
Please, go through these checks before submitting the PR.