Fix variables handling for forbid_install and forbid_upgrade.#2
Open
eesprit wants to merge 2 commits intoannttu:masterfrom
eesprit:master
Open
Fix variables handling for forbid_install and forbid_upgrade.#2eesprit wants to merge 2 commits intoannttu:masterfrom eesprit:master
eesprit wants to merge 2 commits intoannttu:masterfrom
eesprit:master
Conversation
added 2 commits
August 12, 2015 10:09
With the previous code, defining one of those to either false or true was always ending with $FORBID_UPGRADE=1 or $FORBID_INSTALL=1 because it was only testing if the variable has been defined, not its value. Also reorganised the logic of the role with better default handling and variable names fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the previous code, defining one of those to either false or true
was always ending with $FORBID_UPGRADE=1 or $FORBID_INSTALL=1 because
it was only testing if the variable has been defined, not its value.
Also reorganised the logic of the role with better default handling
and variable names fixes.