fix: honest mesh + wallet state by epicexcelsior · Pull Request #48 · anonmesh/mobile_app

epicexcelsior · 2026-05-15T08:24:31Z

Five honesty fixes — every present-tense claim in the UI now reflects actual state.

fix(messages): enc:false on insert, flip to true only on messageDelivered — screens/MessagesScreen.tsx. Lock icon was set the moment a send was queued, so failed sends + still-in-flight sends both painted as encrypted on the wire. resolveSeq extended: when state === 'delivered', reverse-lookup msgId via idToSeqRef and flip enc on the matching ChatMsg.
fix(beacon): drop silent auto-activation on first internet — components/nodes/BeaconRegistry.tsx. Beacon mode (relays others' traffic, co-signs Solana txs) was being flipped on without consent the first time the device saw internet. Removed the useEffect; user must tap Register-as-Beacon.
fix(nodes): replace 7-fake-peer fallback with honest empty state — screens/NodesScreen.tsx + components/nodes/constants.ts. When LXMF wasn't running, the radar filled from a hardcoded 7-item fixture (NODES export), painting @beacon_prime · 12ms etc. on a totally cold device. Fixture deleted; empty overlay reads "Starting mesh…" (native available) or "Mesh unavailable on this device".
fix(settings): drop hardcoded 78% BATT pill — screens/SettingsScreen.tsx. PairedDevice has no battery field; pill rendered "78% BATT" on every paired card regardless. Removed. Comment in place for when the pairing API exposes real battery.
fix(send): disable Send tile in isolated mode at render-time — screens/WalletScreen.tsx. Send tile fired router.push('/send/recipient') regardless of network state; user walked 3 screens then hit "no Solana RPC route available" at confirm. Now dims the tile + overlays a NO ROUTE pill up front. Confirm-time bail in ReviewCard:216-223 kept as defense-in-depth for mid-flow mode changes.

Test plan

Notes

Some existing issues to group chat DMs. Fixes still relevant but need to test messaging transports separately.

Lock icon (enc:true) was set the moment a send was queued, so failed sends and still-in-flight sends both rendered as encrypted on the wire — a present-tense factual claim that isn't true. AUDIT T9 / ROADMAP § 0.3. Sets enc:false on insert; resolveSeq flips it to true only when the native module emits messageDelivered for the corresponding seq. Reverse-lookup msgId via idToSeqRef so the existing seq→msg map stays load-bearing.

…ternet BeaconRegistry flipped the user into beacon mode silently the first time the device saw internet — beacon mode relays others' traffic and co-signs Solana txs, so opting users in without a tap is a consent violation per AUDIT T10 / ROADMAP § 0.B.3. Drops the auto-activate useEffect. The Register-as-Beacon control (via setBeaconMode) stays — it's now the only way to enter beacon mode. autoActivatedRef + useEffect import follow it out.

When LXMF wasn't running yet, NodesScreen filled the radar from a 7-item fixture (constants NODES) — same renderer as live peers, so users saw '@beacon_prime · 12ms' on a totally cold device. That's a lie about current mesh state, not a roadmap signal. AUDIT T7 / ROADMAP § 0.4. Removes the NODES fixture and the fallback. The radar now shows real peers only; when empty, an overlay reads 'Starting mesh…' (native module available) or 'Mesh unavailable on this device' (no native).

PairedDevice doesn't carry battery telemetry — the pill rendered '78% BATT' on every paired-device card regardless of actual battery state. Removed for now; when the pairing API exposes a real battery field, swap this back to a live readout. AUDIT T11 / ROADMAP § 0.B.5.

Send tile fired `router.push('/send/recipient')` regardless of network state — user picked a recipient, typed an amount, slid to confirm, and only at the confirm step got "no Solana RPC route is available" (ReviewCard.tsx:216-223). Now disables the tile up front when mode === 'isolated' and overlays a NO ROUTE pill so the dead-end is visible from wallet home. Keeps the confirm-time bail as defense-in-depth for the mid-flow mode-change race. ROADMAP § 2.4 / 02-UX P0 anonmesh#6.

Copilot

Pull request overview

This PR makes several UI state claims reflect live app/network state instead of optimistic or hardcoded values.

Changes:

Delays outbound message encryption indicators until delivery confirmation.
Removes fake mesh peers, beacon auto-activation, and hardcoded hardware battery text.
Disables the Wallet Send tile when no RPC route is available.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`mobile_app/screens/WalletScreen.tsx`	Adds isolated-mode Send tile disabling and “NO ROUTE” badge.
`mobile_app/screens/SettingsScreen.tsx`	Removes hardcoded paired-device battery pill.
`mobile_app/screens/NodesScreen.tsx`	Uses real peer data only and shows mesh empty-state copy.
`mobile_app/screens/MessagesScreen.tsx`	Initializes sent text bubbles as unlocked and flips lock on delivery events.
`mobile_app/components/nodes/constants.ts`	Removes the fake `NODES` fixture export.
`mobile_app/components/nodes/BeaconRegistry.tsx`	Removes automatic beacon activation on internet availability.

Comments suppressed due to low confidence (1)

mobile_app/screens/WalletScreen.tsx:138

useNetworkMode() initializes its internet state as online and only corrects it after the async NetInfo event/fetch, so isolated is false on the first render even for an offline/no-relay cold start. That leaves the Send tile briefly enabled and tappable, which undermines the render-time gate this change is adding; treat the initial network state as unresolved/offline for this affordance or gate on a resolved mode from the parent.

  const { mode } = useNetworkMode();
  const isolated = mode === 'isolated';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+  void hasInternet;
+  void setBeaconMode;


+      if (msgIdForSeq !== null) {
+        setMsgs(prev => prev.map(m =>
+          m.id === msgIdForSeq && 'enc' in m ? { ...m, enc: true } : m,
+        ));


epicexcelsior · 2026-05-15T09:11:56Z

 function ActionTiles() {
  const { colors } = useTheme();
  const router = useRouter();
+  // Gate the Send tile at render-time so isolated-mode users can't walk three
+  // screens deep before the confirm-step error tells them no RPC route exists.
+  // ROADMAP § 2.4 / 02-UX P0 #6.
+  const { mode } = useNetworkMode();
+  const isolated = mode === 'isolated';


Real concern at this branch's diff base (upstream/v3 c6738d6 — pre-context useNetworkMode). After PR #47 merged to v3, useNetworkMode is now a useContext shim — the second call here is just a context lookup, not a fresh NetInfo subscription or MeshRpcAdapter instance. Resolved by the merge order A → C → B → D.

Without the auto-activate useEffect (removed in 78a801d), there was no remaining path to flip beacon mode on — the modal's CTA was pointerEvents:none + 'Preview — not yet active'. Replaces the disabled preview with a real Pressable that calls setBeaconMode(true) + dismisses the modal. Stake + biometric co-sign flow remain future work; the JS-side opt-in is the consent gate today.

resolveSeq only updated the currently-rendered msgs array, so if the user navigated away from a thread before native emitted messageDelivered, the sent bubble in threadsRef stayed at enc:false. Reopening the conversation showed no lock even though delivery had been confirmed. Now also walks threadsRef and rewrites any cached thread containing the seq's msgId.

* fix(messages): enc:false on insert; flip to true on messageDelivered Lock icon (enc:true) was set the moment a send was queued, so failed sends and still-in-flight sends both rendered as encrypted on the wire — a present-tense factual claim that isn't true. AUDIT T9 / ROADMAP § 0.3. Sets enc:false on insert; resolveSeq flips it to true only when the native module emits messageDelivered for the corresponding seq. Reverse-lookup msgId via idToSeqRef so the existing seq→msg map stays load-bearing. * fix(beacon): require explicit opt-in instead of auto-activating on internet BeaconRegistry flipped the user into beacon mode silently the first time the device saw internet — beacon mode relays others' traffic and co-signs Solana txs, so opting users in without a tap is a consent violation per AUDIT T10 / ROADMAP § 0.B.3. Drops the auto-activate useEffect. The Register-as-Beacon control (via setBeaconMode) stays — it's now the only way to enter beacon mode. autoActivatedRef + useEffect import follow it out. * fix(nodes): drop 7-fake-peer fallback for honest empty state When LXMF wasn't running yet, NodesScreen filled the radar from a 7-item fixture (constants NODES) — same renderer as live peers, so users saw '@beacon_prime · 12ms' on a totally cold device. That's a lie about current mesh state, not a roadmap signal. AUDIT T7 / ROADMAP § 0.4. Removes the NODES fixture and the fallback. The radar now shows real peers only; when empty, an overlay reads 'Starting mesh…' (native module available) or 'Mesh unavailable on this device' (no native). * fix(settings): drop hardcoded 78% BATT pill from paired-hardware card PairedDevice doesn't carry battery telemetry — the pill rendered '78% BATT' on every paired-device card regardless of actual battery state. Removed for now; when the pairing API exposes a real battery field, swap this back to a live readout. AUDIT T11 / ROADMAP § 0.B.5. * fix(send): disable Send tile in isolated mode at render-time Send tile fired `router.push('/send/recipient')` regardless of network state — user picked a recipient, typed an amount, slid to confirm, and only at the confirm step got "no Solana RPC route is available" (ReviewCard.tsx:216-223). Now disables the tile up front when mode === 'isolated' and overlays a NO ROUTE pill so the dead-end is visible from wallet home. Keeps the confirm-time bail as defense-in-depth for the mid-flow mode-change race. ROADMAP § 2.4 / 02-UX P0 #6. * fix(beacon): wire Register-as-Beacon CTA to setBeaconMode Without the auto-activate useEffect (removed in 78a801d), there was no remaining path to flip beacon mode on — the modal's CTA was pointerEvents:none + 'Preview — not yet active'. Replaces the disabled preview with a real Pressable that calls setBeaconMode(true) + dismisses the modal. Stake + biometric co-sign flow remain future work; the JS-side opt-in is the consent gate today. * fix(messages): also flip enc on cached non-active threads resolveSeq only updated the currently-rendered msgs array, so if the user navigated away from a thread before native emitted messageDelivered, the sent bubble in threadsRef stayed at enc:false. Reopening the conversation showed no lock even though delivery had been confirmed. Now also walks threadsRef and rewrites any cached thread containing the seq's msgId.

epicexcelsior added 5 commits May 14, 2026 04:51

epicexcelsior mentioned this pull request May 15, 2026

fix: correctness pass — security + copy + UX #49

Merged

17 tasks

epicexcelsior marked this pull request as ready for review May 15, 2026 08:48

epicexcelsior requested a review from Copilot May 15, 2026 08:58

Copilot started reviewing on behalf of epicexcelsior May 15, 2026 08:59 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

epicexcelsior added 2 commits May 15, 2026 01:10

epicexcelsior merged commit f6ba506 into anonmesh:v3 May 15, 2026
1 check passed

epicexcelsior deleted the epic/honest-state-batch branch May 15, 2026 09:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: honest mesh + wallet state#48

fix: honest mesh + wallet state#48
epicexcelsior merged 7 commits into
anonmesh:v3from
epicexcelsior:epic/honest-state-batch

epicexcelsior commented May 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

epicexcelsior May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

epicexcelsior commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

epicexcelsior May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

epicexcelsior commented May 15, 2026 •

edited

Loading