Fix the log levels mapping

[Jakuje]

SUMMARY

The libssh provides the most verbose logging with SSH_LOG_TRACE, which was mapped to logging.CRITICAL, causing the users being unable to get full debug logs. These are critical for libssh developers to be able to investigate issues.

ISSUE TYPE

• Bugfix Pull Request

[webknjaz]

It'd be useful to have tests in such PRs. I'm unable to verify what this patch affects without them.

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/ansible-pylibssh-597
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[Jakuje]

@webknjaz the current version should be working version with tests of what, I hope, you were trying to describe. I think it will need some polishing so I would be happy for your inputs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[webknjaz]

I wrote most of the review months ago. Submitting just now. This might need a few more iterations. Hopefully, a few things are actionable immediately.

[Jakuje]

Turns out that also the logging.NOTSET is misplaced. In python it means "ask above"/"log everything" but in libssh the currently mapped value libssh.SSH_LOG_NONE means do not log anything, which is quite the opposite so my suggestion would be to move this to logging.WARNING which is probably the closest ...

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[webknjaz]

Turns out that also the logging.NOTSET is misplaced. In python it means "ask above"/"log everything" but in libssh the currently mapped value libssh.SSH_LOG_NONE means do not log anything, which is quite the opposite so my suggestion would be to move this to logging.WARNING which is probably the closest ...

If you want a "log nothing", I'd probably set the threshold high in the mapping. Something like 55 or 60, or even 99:

$ python
Python 3.13.2 (main, Feb 28 2025, 20:34:46) [GCC 14.2.1 20241221] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import logging
>>> logging.getLevelNamesMapping()
{'CRITICAL': 50, 'FATAL': 50, 'ERROR': 40, 'WARN': 30, 'WARNING': 30, 'INFO': 20, 'DEBUG': 10, 'NOTSET': 0}
>>> logging.fatal
<function fatal at 0x7fa77ea62fc0>
>>> logging.CRITICAL
50
>>> logging.FATAL
50
>>> logging.ERROR
40

P.S. I wonder if float('inf') would be allowed since infinity is semantically what you're after...

[webknjaz]

My final review pass gives a few grammar hints but the main concern is the configuration mismatch between the fixture and the tests (provided that the docs edits are cosmetic/secondary).

[Jakuje]

I hope I addressed all your comments now. Please have a look

[webknjaz]

FTR, the last failure is flaky #756 (comment)

[Jakuje]

FTR, the last failure is flaky #756 (comment)

Saw that, but did not bother with that as it looks like its not the last version as we needed to clarify the testing in the last comment.