And 87 fiks maven artifacts publisering by jeeveshmishra · Pull Request #86 · anskaffelser/vefa-validator

jeeveshmishra · 2026-05-13T09:23:23Z

Denne Pull request innbærer:

Bruk av riktig token for Maven artifacts deploy.
Oppgradering av Java versjon og bruk av riktig maven for devcontainer.

Bumpet opp versjon på alle pom filer.

Copilot

Pull request overview

Oppdaterer CI og devcontainer-oppsett for å støtte Maven artifact-publisering mot GitHub Packages, samt moderniserer utviklingsmiljøet til Java 21.

Changes:

Konfigurerer actions/setup-java og legger til egen Maven deploy-step i GitHub Actions.
Oppgraderer devcontainer-baseimage til Java 21 (Bookworm) og installerer Maven i containeren.
Justerer devcontainer metadata/innstillinger og verifiserer toolchain ved oppstart.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
.github/workflows/build.yml	Legger til Maven publishing-konfig og `mvn deploy` i CI.
.devcontainer/Dockerfile	Bytter til Java 21 devcontainer-image og installerer Maven.
.devcontainer/devcontainer.json	Oppdaterer devcontainer-konfig til Java 21 + postCreate verifisering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tbitu

server-id github kommer antakelig ikke til å fungere, det bør vel være anskaffelser siden det står i pom.xml. Tokenet bør også være det innebygde github_token så vi slipper å vedlikeholde et eget, det bør virke? I tillegg bør vi ikke pinne maven-versjon med mindre det er helt nødvendig.

tbitu

Kan også bumpe til 2.4.1 siden dette skal fikse artifaktpublisering.

…navn eller organisation navn.

…riable.

jeeveshmishra · 2026-05-13T11:13:02Z

vedlikeholde

Bumpet opp versjon som 2.4.1 og bruker bare GITHUB_TOKEN med selskaps navn som server-id.

tbitu

devcontainer.json pinner fremdeles maven-version

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

.github/workflows/build.yml:52

PACKAGES_TOKEN is exported for the deploy step, but with the current setup-java configuration it isn't referenced by Maven settings (server-password points at GITHUB_TOKEN). Either wire it up via server-password: PACKAGES_TOKEN or drop this env var so the workflow doesn’t suggest it’s being used when it isn’t.

        run: mvn --batch-mode deploy
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          PACKAGES_TOKEN: ${{ secrets.GH_PACKAGES_TOKEN }}

    <artifactId>validator-parent</artifactId>
    <packaging>pom</packaging>
-    <version>2.4.0-SNAPSHOT</version>
+    <version>2.4.1-SNAPSHOT</version>


tbitu

Selve deploy-prosessen bruker fremdeles secrets.GH_PACKAGES_TOKEN.

jeeveshmishra · 2026-05-13T11:26:09Z

devcontainer.json pinner fremdeles maven-version

Da er den også bort fra denne filen.

… brukes.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

.github/workflows/build.yml:50

The workflow runs mvn ... package and then (on main/tags) runs mvn ... deploy, which re-executes the full build lifecycle (including tests) a second time. Consider running a single Maven invocation (conditional deploy vs verify/package), or running verify once and then deploy with tests skipped to avoid doubling CI time.

      - name: Build with Maven
        run: mvn -B --no-transfer-progress package

      - name: Publish to GitHub Packages
        if: ( github.event_name == 'push' || github.event_name == 'workflow_dispatch' ) && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/'))
        run: mvn --batch-mode deploy
        env:

.github/workflows/build.yml:49

Publish to GitHub Packages is enabled for release-like tags (*.*.*), but the project version is a -SNAPSHOT. Tag builds will therefore deploy snapshot artifacts, which is usually unexpected for release tags. Either restrict Maven deploy to main only, or switch to a non-snapshot version as part of the tag/release process.

      - name: Publish to GitHub Packages
        if: ( github.event_name == 'push' || github.event_name == 'workflow_dispatch' ) && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/'))
        run: mvn --batch-mode deploy

jeeveshmishra · 2026-05-13T11:30:35Z

Selve deploy-prosessen bruker fremdeles secrets.GH_PACKAGES_TOKEN.

Denne token er bort nå.

…nsj.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

.github/workflows/build.yml:52

The deploy step drops --no-transfer-progress / -B used in the build step, which can make CI logs noisier and less consistent. Consider using the same Maven flags here as in the build step.

      - name: Publish to GitHub Packages
        if: ( github.event_name == 'push' || github.event_name == 'workflow_dispatch' ) && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/'))
        run: mvn --batch-mode deploy
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

… maven packages step.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

+          # Defaults to GITHUB_ACTOR (the user who triggered the workflow)
+          server-username: GITHUB_ACTOR
+          # Defaults to GITHUB_TOKEN
+          server-password: GITHUB_TOKEN


+
+      - name: Publish to GitHub Packages
+        if: ( github.event_name == 'push' || github.event_name == 'workflow_dispatch' ) && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/'))
+        run: mvn --no-transfer-progress deploy


+      - name: Publish to GitHub Packages
+        if: ( github.event_name == 'push' || github.event_name == 'workflow_dispatch' ) && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/'))
+        run: mvn --no-transfer-progress deploy
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}


…nsj.

…package skal det være batch basert publisering med option -B.

…step.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

+          server-id: anskaffelser
+          # Defaults to GITHUB_ACTOR (the user who triggered the workflow)
+          server-username: GITHUB_ACTOR
+          # Defaults to GITHUB_TOKEN
+          server-password: GITHUB_TOKEN


…version}

…as now the java does not comes from sdkman, however, from microsoft open jdk .

…rtifacts step.

tbitu · 2026-05-13T11:31:24Z

INSTALL_MAVEN er gjort om til false, men koden kjører mvn -version senere. Virker det?

jeeveshmishra added 2 commits May 13, 2026 11:18

AND-87 Fikset dev container for å bruke riktig versjon av Java og Maven

e257b26

AND-87 Fikset publisering av Maven artifektene med bruk av riktig token.

9bd2518

jeeveshmishra requested review from Copilot and fsandvold May 13, 2026 09:23

Copilot started reviewing on behalf of jeeveshmishra May 13, 2026 09:24 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .devcontainer/devcontainer.json Outdated

tbitu requested changes May 13, 2026

View reviewed changes

tbitu reviewed May 13, 2026

View reviewed changes

jeeveshmishra added 4 commits May 13, 2026 12:35

AND-87 Rolled back installasjon av maven 3.9.15

b79876e

AND-87 bruk av riktig server-id for å matche settings.xml og selskaps…

9b7274c

…navn eller organisation navn.

AND-87 bruk av GITHUB_TOKEN istedet for token konfigurert som miljø v…

4233dbc

…riable.

AND-87 bumpet opp versjon til 2.4.1

5cebea3

jeeveshmishra requested review from Copilot and tbitu May 13, 2026 11:13

Copilot started reviewing on behalf of jeeveshmishra May 13, 2026 11:16 View session

tbitu requested changes May 13, 2026

View reviewed changes

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread pom.xml

<artifactId>validator-parent</artifactId>

<packaging>pom</packaging>

<version>2.4.0-SNAPSHOT</version>

<version>2.4.1-SNAPSHOT</version>

Comment thread pom.xml

tbitu requested changes May 13, 2026

View reviewed changes

AND-87 Tatt bort MAVEN_VERSION parameter.

6dc3fda

jeeveshmishra requested review from Copilot and tbitu May 13, 2026 11:26

Copilot started reviewing on behalf of jeeveshmishra May 13, 2026 11:26 View session

AND-87 Tatt bort PACKAGE_TOKEN fra hele build.xml siden den skal ikke…

7071c91

… brukes.

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread .github/workflows/build.yml

Comment thread .devcontainer/devcontainer.json Outdated

jeeveshmishra added 2 commits May 13, 2026 13:33

AND-87 ut-kommentert postCreateCommand siden det var son i master bra…

3147328

…nsj.

AND-87 Tatt bort unødvendig komma.

d94a8cb

jeeveshmishra requested a review from Copilot May 13, 2026 11:34

Copilot started reviewing on behalf of jeeveshmishra May 13, 2026 11:34 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment thread .github/workflows/build.yml Outdated

jeeveshmishra added 2 commits May 13, 2026 13:57

AND-87 bruk av ${project.version} variable

bcdf30a

AND-87 Fikset copilot review kommetar for maven build step og publish…

0730eba

… maven packages step.

jeeveshmishra requested a review from Copilot May 13, 2026 12:02

Copilot started reviewing on behalf of jeeveshmishra May 13, 2026 12:03 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

jeeveshmishra added 4 commits May 13, 2026 15:19

AND-87 rullet tilbake install node flag slik som det var på main bransj.

12728bb

AND-87 rullet tilbake install maven flag slik som det var på main bra…

3227843

…nsj.

AND-87 rullet tilbake for bruk av GH_PACKAGES_TOKEN og under publish …

e2fdc1c

…package skal det være batch basert publisering med option -B.

AND-87 bruk av GITHUB_TOKEN i sted for PACKAGES_TOKEN for Set up JDK …

bac7f27

…step.

jeeveshmishra requested a review from Copilot May 13, 2026 13:41

Copilot started reviewing on behalf of jeeveshmishra May 13, 2026 13:42 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

Comment on lines +38 to +42

server-id: anskaffelser

# Defaults to GITHUB_ACTOR (the user who triggered the workflow)

server-username: GITHUB_ACTOR

# Defaults to GITHUB_TOKEN

server-password: GITHUB_TOKEN

jeeveshmishra added 5 commits May 15, 2026 11:51

AND-87 Rolled back to specific version instead of variable ${project.…

98a7944

…version}

AND-87 used packages token as server password.

032b462

AND-87 used docker-java-home as java home and changed paths for java …

c36f760

…as now the java does not comes from sdkman, however, from microsoft open jdk .

AND-87 changed path from /user to /usr

adf1abf

AND-87 removed GITHUB_TOKEN as environment variable from maven push a…

8b8e074

…rtifacts step.

tbitu approved these changes May 15, 2026

View reviewed changes

jeeveshmishra merged commit a58c9d4 into main May 15, 2026
1 check passed

jeeveshmishra deleted the AND-87-Fiks-Maven-Artifacts-Publisering branch May 15, 2026 13:07

Conversation

jeeveshmishra commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

tbitu left a comment

Choose a reason for hiding this comment

Uh oh!

tbitu left a comment

Choose a reason for hiding this comment

Uh oh!

jeeveshmishra commented May 13, 2026

Uh oh!

tbitu left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

tbitu left a comment

Choose a reason for hiding this comment

Uh oh!

jeeveshmishra commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

jeeveshmishra commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

tbitu May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jeeveshmishra commented May 13, 2026 •

edited

Loading