refactor: split check licenses logic into separate steps#1363
Open
SMoraisAnsys wants to merge 7 commits into
Open
refactor: split check licenses logic into separate steps#1363SMoraisAnsys wants to merge 7 commits into
SMoraisAnsys wants to merge 7 commits into
Conversation
SMoraisAnsys
commented
Jun 18, 2026
SMoraisAnsys
commented
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like we did for safety, the idea of this PR is to split the installation into two venvs. One only contains
pip-licensesand its dependencies while the other contains the project + extra or the provided path to a venv. The idea is to leverage the python option which allows to select a specific python path to check.I've a successful usage in pyaedt: here is an expected working workflow (many other are working too) and here is an expected failing workflow.