Skip to content

fix(plugins): add SKILL.md frontmatter, repair hooks.json, dedupe spglobal MCP#243

Open
mattpic-ant wants to merge 1 commit into
mainfrom
fix/plugin-skill-frontmatter
Open

fix(plugins): add SKILL.md frontmatter, repair hooks.json, dedupe spglobal MCP#243
mattpic-ant wants to merge 1 commit into
mainfrom
fix/plugin-skill-frontmatter

Conversation

@mattpic-ant
Copy link
Copy Markdown
Collaborator

Summary

Applies a patch from Jake Marsh fixing marketplace loader rejections (9 of 20 plugins failed on sync):

  • 29 vertical-plugin SKILL.md sources had no YAML frontmatter — the skill name/description sat in the body as a bare description: line after the # Title H1. Synthesized proper --- name/description --- frontmatter (name = skill dir, description = the existing body text), matching the loading skills (e.g. fund-admin/accrual-schedule). Agent bundles re-synced via scripts/sync-agent-skills.py (12 copies).
  • hooks/hooks.json was [] in 4 plugins; the loader requires a JSON object. Changed to { "hooks": {} } — the form investment-banking already uses and that synced clean. (These were already fixed on main in fix(plugins): repair broken hooks.json + add plugin-validate CI #232, so they resolved as no-ops here.)
  • partner-built/spglobal defined the spglobal MCP server both inline in plugin.json and in .mcp.json (identical). Dropped the inline copy; .mcp.json is the canonical location.

Notes

  • Applied via git apply --3way since main had advanced past the patch base (fix(plugins): repair broken hooks.json + add plugin-validate CI #232 already covered the hooks.json fixes and some version bumps); financial-analysis dropped out entirely as a net no-op.
  • Pre-commit hook re-bumped equity-research, private-equity, and wealth-management to 0.1.2 to stay exactly one patch ahead of main.

Verification

  • python3 scripts/check.py — OK, 80 files, 0 issues.

…lobal MCP

The marketplace loader rejected 9 of 20 plugins on sync:

- 29 vertical-plugin SKILL.md sources had no YAML frontmatter — the
  skill name/description sat in the body as a bare `description:` line
  after the `# Title` H1. Synthesized proper `--- name/description ---`
  frontmatter (name = skill dir, description = the existing body text),
  matching the loading skills (e.g. fund-admin/accrual-schedule). Agent
  bundles re-synced via scripts/sync-agent-skills.py (12 copies).
- 4 hooks/hooks.json were `[]`; the loader requires a JSON object.
  Changed to `{ "hooks": {} }` — the form investment-banking already
  uses and that synced clean.
- partner-built/spglobal defined the `spglobal` MCP server both inline
  in plugin.json and in .mcp.json (identical). Dropped the inline copy;
  .mcp.json is the canonical location.

scripts/check.py: OK — 80 files, 0 issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants