fix(plugins): add SKILL.md frontmatter, repair hooks.json, dedupe spglobal MCP#243
Open
mattpic-ant wants to merge 1 commit into
Open
fix(plugins): add SKILL.md frontmatter, repair hooks.json, dedupe spglobal MCP#243mattpic-ant wants to merge 1 commit into
mattpic-ant wants to merge 1 commit into
Conversation
…lobal MCP
The marketplace loader rejected 9 of 20 plugins on sync:
- 29 vertical-plugin SKILL.md sources had no YAML frontmatter — the
skill name/description sat in the body as a bare `description:` line
after the `# Title` H1. Synthesized proper `--- name/description ---`
frontmatter (name = skill dir, description = the existing body text),
matching the loading skills (e.g. fund-admin/accrual-schedule). Agent
bundles re-synced via scripts/sync-agent-skills.py (12 copies).
- 4 hooks/hooks.json were `[]`; the loader requires a JSON object.
Changed to `{ "hooks": {} }` — the form investment-banking already
uses and that synced clean.
- partner-built/spglobal defined the `spglobal` MCP server both inline
in plugin.json and in .mcp.json (identical). Dropped the inline copy;
.mcp.json is the canonical location.
scripts/check.py: OK — 80 files, 0 issues.
alexa-perlov
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies a patch from Jake Marsh fixing marketplace loader rejections (9 of 20 plugins failed on sync):
SKILL.mdsources had no YAML frontmatter — the skill name/description sat in the body as a baredescription:line after the# TitleH1. Synthesized proper--- name/description ---frontmatter (name= skill dir,description= the existing body text), matching the loading skills (e.g.fund-admin/accrual-schedule). Agent bundles re-synced viascripts/sync-agent-skills.py(12 copies).hooks/hooks.jsonwas[]in 4 plugins; the loader requires a JSON object. Changed to{ "hooks": {} }— the forminvestment-bankingalready uses and that synced clean. (These were already fixed onmainin fix(plugins): repair broken hooks.json + add plugin-validate CI #232, so they resolved as no-ops here.)partner-built/spglobaldefined thespglobalMCP server both inline inplugin.jsonand in.mcp.json(identical). Dropped the inline copy;.mcp.jsonis the canonical location.Notes
git apply --3waysincemainhad advanced past the patch base (fix(plugins): repair broken hooks.json + add plugin-validate CI #232 already covered thehooks.jsonfixes and some version bumps);financial-analysisdropped out entirely as a net no-op.equity-research,private-equity, andwealth-managementto0.1.2to stay exactly one patch ahead ofmain.Verification
python3 scripts/check.py— OK, 80 files, 0 issues.