test(hardware): add comprehensive integration tests for hardware graph#240
Closed
jra3 wants to merge 2 commits into
Closed
test(hardware): add comprehensive integration tests for hardware graph#240jra3 wants to merge 2 commits into
jra3 wants to merge 2 commits into
Conversation
24d21ad to
1e872aa
Compare
Collaborator
Author
CI Status UpdateAll test-related CI checks are passing ✅:
Infrastructure Failures (Unrelated to This PR)The following failures are GitHub Actions infrastructure issues affecting the base branch:
These same failures occur on The comprehensive hardware graph integration tests are working correctly and ready for review. |
5acd817 to
f6c7e87
Compare
Add extensive integration test suite covering real-world hardware discovery scenarios, performance benchmarking, edge case handling, and reusable test fixtures for hardware graph module. Test coverage includes: - Real system hardware discovery using actual /proc and /sys data - Multi-socket server topologies with NUMA configurations - Cloud provider patterns (AWS c5/m5, GCP n2, Azure D-series) - Storage configurations (NVMe, HDD arrays, mixed storage) - Network topologies (bonding, SR-IOV, virtual interfaces) - Partial failure scenarios with graceful degradation - Edge cases (empty fields, inconsistent data, extreme values) - Performance benchmarks for various system sizes (VM to large server) The test fixtures provide reusable generators for CPU cores, NUMA nodes, disk configurations, and network interfaces to support future test development without duplication. Closes #163 Co-Authored-By: Claude <noreply@anthropic.com>
69ae900 to
d444841
Compare
- Revert .wiki submodule to match main (per CLAUDE.md guidelines) - Fix generateLargeServerDisks: use fmt.Sprintf for proper NVMe/SATA naming - Fix generateManyNetworkInterfaces: use fmt.Sprintf for i >= 10 - Remove unnecessary b.StartTimer() at end of benchmark loop - Remove skipped TestBuilder_ConcurrentBuilds (reduces noise) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive integration test suite for the hardware graph module covering real-world hardware discovery scenarios, performance benchmarking, and edge case handling.
Changes
New Test Files
builder_integration_test.go- Integration tests for real-world scenarios:builder_benchmark_test.go- Performance benchmarks:builder_edge_cases_test.go- Edge case and error handling:test_fixtures_test.go- Reusable test fixture generators:Test Coverage
All success criteria from issue #163 are met:
✅ Phase 1: Core Integration Tests
✅ Phase 2: Edge Case Coverage
✅ Phase 3: Real-World Validation
Running the Tests
Test Results
All tests pass successfully and demonstrate that the hardware graph builder:
Related Issues
Closes #163
Related