Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/forge_app/src/git_app.rs
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ where
Ok(provider) => (provider, commit_model),
Err(err) => {
tracing::warn!(
error = %err,
error = ?err,
"Failed to refresh credentials for configured commit provider. Falling back to the active provider."
);
self.resolve_agent_provider_and_model(
Expand All @@ -336,7 +336,7 @@ where
}
Err(err) => {
tracing::warn!(
error = %err,
error = ?err,
"Configured commit provider unavailable. Falling back to the active provider."
);
self.resolve_agent_provider_and_model(&agent_provider_resolver, agent_id)
Expand Down
2 changes: 1 addition & 1 deletion crates/forge_app/src/hooks/title_generation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ impl<S: AgentService> EventHandle<EventData<EndPayload>> for TitleGenerationHand
self.title_tasks.remove(&conversation.id);
}
Err(e) => {
debug!(error = %e, "Title generation task failed");
debug!(error = ?e, "Title generation task failed");
// Remove so a future StartPayload can retry.
self.title_tasks.remove(&conversation.id);
}
Expand Down
4 changes: 2 additions & 2 deletions crates/forge_repo/src/app_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ impl<F: EnvironmentInfra + FileReaderInfra + FileWriterInfra> AppConfigRepositor
Err(e) => {
tracing::error!(
path = %path.display(),
error = %e,
error = ?e,
"Failed to read config file. Using default config."
);
return AppConfig::default();
Expand All @@ -59,7 +59,7 @@ impl<F: EnvironmentInfra + FileReaderInfra + FileWriterInfra> AppConfigRepositor
.inspect_err(|e| {
tracing::error!(
path = %path.display(),
error = %e,
error = ?e,
"Failed to repair config file. Using default config."
);
})
Expand Down
6 changes: 3 additions & 3 deletions crates/forge_repo/src/database/pool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ impl DatabasePool {

pub fn get_connection(&self) -> Result<PooledSqliteConnection> {
self.pool.get().map_err(|e| {
warn!(error = %e, "Failed to get connection from pool");
warn!(error = ?e, "Failed to get connection from pool");
anyhow::anyhow!("Failed to get connection from pool: {e}")
})
}
Expand Down Expand Up @@ -123,7 +123,7 @@ impl TryFrom<PoolConfig> for DatabasePool {
}

let pool = builder.build(manager).map_err(|e| {
warn!(error = %e, "Failed to create connection pool");
warn!(error = ?e, "Failed to create connection pool");
anyhow::anyhow!("Failed to create connection pool: {e}")
})?;

Expand All @@ -133,7 +133,7 @@ impl TryFrom<PoolConfig> for DatabasePool {
.map_err(|e| anyhow::anyhow!("Failed to get connection for migrations: {e}"))?;

connection.run_pending_migrations(MIGRATIONS).map_err(|e| {
warn!(error = %e, "Failed to run database migrations");
warn!(error = ?e, "Failed to run database migrations");
anyhow::anyhow!("Failed to run database migrations: {e}")
})?;

Expand Down
6 changes: 3 additions & 3 deletions crates/forge_repo/src/provider/chat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ impl<F: EnvironmentInfra + HttpInfra + Sync> ChatRepository for ForgeChatReposit
match router.models(provider).await {
Ok(models) => {
if let Err(err) = cache.cache_set(&key, &models).await {
tracing::warn!(error = %err, "background refresh: failed to cache model list");
tracing::warn!(error = ?err, "background refresh: failed to cache model list");
}
}
Err(err) => {
tracing::warn!(error = %err, "background refresh: failed to fetch models");
tracing::warn!(error = ?err, "background refresh: failed to fetch models");
}
}
});
Expand All @@ -113,7 +113,7 @@ impl<F: EnvironmentInfra + HttpInfra + Sync> ChatRepository for ForgeChatReposit
let models = self.router.models(provider).await?;

if let Err(err) = self.model_cache.cache_set(&cache_key, &models).await {
tracing::warn!(error = %err, "failed to cache model list");
tracing::warn!(error = ?err, "failed to cache model list");
}

Ok(models)
Expand Down
Loading