Skip to content

fix(zsh): prevent output truncation by using send-break for prompt reset #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssddOnTop wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −3
Open

fix(zsh): prevent output truncation by using send-break for prompt reset #2567

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7869917
fix(zsh): use .send-break to avoid stale cursor redraw on reset
ssddOnTop Mar 14, 2026
e414cad
Merge branch 'main' into fix/line-truncation
ssddOnTop Mar 15, 2026
33879e6
Merge branch 'main' into fix/line-truncation
tusharmath Mar 15, 2026
c5d1d4e
fix(zsh): use .accept-line instead of .send-break in forge reset
ssddOnTop Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions shell-plugin/lib/helpers.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,8 @@ function _forge_reset() {
# Clear buffer and reset cursor position
BUFFER=""
CURSOR=0
# Force widget redraw and prompt reset
zle -I
zle reset-prompt

zle .accept-line
Copy link
Contributor

@graphite-app graphite-app bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation does not match the PR description. The code calls zle .accept-line but the description explicitly states the fix should use zle .send-break. These are fundamentally different ZLE widgets:

  • .accept-line (Enter key) accepts and executes the current line
  • .send-break (Ctrl+G) aborts the current edit cycle and starts fresh

The description's rationale is that .send-break "aborts the current ZLE edit cycle and triggers a fresh prompt cycle at the actual terminal cursor pos", which is the intended behavior. Using .accept-line instead will execute the empty buffer (after BUFFER="") rather than aborting the edit cycle, which may not properly reset the prompt at the correct cursor position.

Fix:

zle .send-break
Suggested change
zle .accept-line
zle .send-break

Spotted by Graphite

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

}


Expand Down
Loading