perf: fast path for zsh rprompt - 55ms to 5ms (8x faster)#2692
Open
AasheeshLikePanner wants to merge 3 commits intoantinomyhq:mainfrom
Open
perf: fast path for zsh rprompt - 55ms to 5ms (8x faster)#2692AasheeshLikePanner wants to merge 3 commits intoantinomyhq:mainfrom
AasheeshLikePanner wants to merge 3 commits intoantinomyhq:mainfrom
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
|
|
|
tusharmath
reviewed
Mar 25, 2026
tusharmath
reviewed
Mar 25, 2026
Bypasses heavy initialization (ForgeInfra, ForgeRepo, ForgeServices) when _FORGE_CONVERSATION_ID is not set.
AasheeshLikePanner
force-pushed
the
fix/2574-zsh-rprompt-perf
branch
from
d9f1666 to
7dd2327
Compare
- Check exact argument positions to avoid false positives - Check BEFORE Cli::parse() to avoid parsing overhead - Falls back to normal path when _FORGE_CONVERSATION_ID is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the flaky zsh rprompt benchmark in #2574 by implementing an early-exit fast path for the
zsh rpromptcommand when no conversation ID is present.Changes
Added a fast path in
main.rsthat checks forzsh rpromptcommand BEFORE any heavy initialization:_FORGE_CONVERSATION_IDis NOT set → print static prompt and exit immediately_FORGE_CONVERSATION_IDIS set → continue with normal full initializationThis bypasses:
Results
Benchmark (CI)
avg: 5ms
p75: 6ms
threshold: 80ms
Status: PASS
Before Screenshot
After Screenshot