Open
Conversation
oxr463
reviewed
Jan 22, 2020
| #define SDS_TYPE_MASK 7 | ||
| #define SDS_TYPE_BITS 3 | ||
| #define SDS_HDR_VAR(T,s) struct sdshdr##T *sh = (void*)((s)-(sizeof(struct sdshdr##T))); | ||
| #define SDS_HDR_VAR(T,s) struct sdshdr##T *sh = (struct sdshdr##T*)((s)-(sizeof(struct sdshdr##T))); |
There was a problem hiding this comment.
Why not stick those in an #ifdef,
#ifdef __cplusplus
#define SDS_HDR_VAR(T,s) struct sdshdr##T *sh = (struct sdshdr##T*)((s)-(sizeof(struct sdshdr##T)));
#else
#define SDS_HDR_VAR(T,s) struct sdshdr##T *sh = (void*)((s)-(sizeof(struct sdshdr##T)));
#endifSource: https://www.cprogramming.com/reference/preprocessor/ifdef.html
Author
|
Is there actually any reason for using a (void*) cast instead of just using (struct sdshdr##T*)? I find #ifdefs rather ugly and I don't see any drawback of casting to (struct sdshdr##T*), but maybe there is some case which I don't see... |
bitbashing
added a commit
to bitbashing/gguf-tools
that referenced
this pull request
Nov 24, 2025
Synchronize with obieq/sds#1 Pending in antirez/sds#125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that sds is a library solely intended for C but I happened to include the header "sds.h" in a C++ application, I don't want to go into details why I needed to do this. However, when compiling the C++ application I get some of these errors:
A minor change in the header would fix this issue. I don't think that it breaks anything, but I think you @antirez know best if it causes side-effects or not.
I've tested this change with in my Application and it works fine in C and C++ so far.