Tony/351 not logged in

[tonypioneer]

Pull Request Details

Description

Fixed the note saving bug when not logged in.

Related Issues

#351

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How To Test?

Run the app. Then create and save a note when not logged in.

Checklist

• Screenshots included here/in linked issue [Bug] Unauthorized guest users can set/save Security Key #351
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[gjwgit]

Is the login required dialog more appropriate for SolidUI?

Will I need to check this in every app or is there some solidui update to support this instead?

[tonypioneer]

Is the login required dialog more appropriate for SolidUI?

Will I need to check this in every app or is there some solidui update to support this instead?

Yes, it's a good point. I'll extract the popup dialog to SolidUI. Thanks @gjwgit.

Currently SolidPod can successfully capture the NotLoggedIn exception. I'll explore whether we can pop up a dialog on the screen automatically by SolidUI.