Amogh/add test new note creation 236#411
Open
Amoghhosamane wants to merge 2 commits into
Open
Conversation
Replace AES encryption of note text with base64 encoding as suggested in issue anusii#272. The rdflib parser cannot handle multiline text with # (hash) values, so encoding is needed. base64 is a simpler and more appropriate solution than AES encryption (which used creation time as key). Decoding falls back to AES decryption for backward compatibility with existing notes that were saved with the old AES-based encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@"
Pull Request Details
Description
Fixes #352 –
showAnimationDialogin Notepod duplicated the implementation from solidui.The wrapper now delegates to
solidui.showAnimationDialog, keeping the same visualbehaviour while removing duplicate code. This also aligns Notepod with the
new_loading_indicator↔loading_indicatordifference.Related Issues
Closes #352
Type of Change
How To Test?
flutter run) on any platform.showAnimationDialog.Checklist
Finalising
devinto this branchCHANGELOG.md