Amogh/backup add test new note creation 236 fresh#415
Open
Amoghhosamane wants to merge 3 commits into
Open
Conversation
Replace AES encryption of note text with base64 encoding as suggested in issue anusii#272. The rdflib parser cannot handle multiline text with # (hash) values, so encoding is needed. base64 is a simpler and more appropriate solution than AES encryption (which used creation time as key). Decoding falls back to AES decryption for backward compatibility with existing notes that were saved with the old AES-based encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Title: Fix macOS foreground issue – activate app on launch to remove “Failed to foreground app; open returned 1” warning
Description
The macOS build of notepod displayed a non‑fatal warning:
This occurs because the Flutter‑generated macOS application does not request activation of the app window after launch, leaving the app in the background.
Added a call to
NSApp.activate(ignoringOtherApps: true)insideapplicationDidFinishLaunchinginmacos/Runner/AppDelegate.swift. This forces the app to become the foreground window when it starts.The warning, while non‑fatal, can obscure real launch issues and degrades the developer experience. Activating the app on launch is the recommended solution per Flutter macOS guidelines.
Related Issues
Type of Change
How To Test?
Checkout the branch
fix/macos-foreground-issue.Run the macOS debug build:
Verify that the console output no longer contains the line “Failed to foreground app; open returned 1” and that the app window appears in the foreground.
(Optional) Run the existing test suite:
make prep && flutter analyze lib && dart test. No new lint errors should appear.Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising
Merge
devinto this branchResolve any conflicts
Add a one‑line summary into the
CHANGELOG.md- Fixed macOS foreground activation to suppress “Failed to foreground app; open returned 1” warning.Push to the git repository and review (already pushed)
Merge the PR into
devReviewers: (please assign appropriate team members)
All steps above have been completed; the PR is ready for review and merge.