Skip to content

Fix Find-Package version range #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasNieto merged 2 commits into from
May 6, 2025
Merged

Fix Find-Package version range #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4380c6d
Fix Find-Package version range
ThomasNieto May 6, 2025
ff5166a
Remove test
ThomasNieto May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/AnyPackage.Npm.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,20 @@ class NpmProvider : PackageProvider, IGetPackage, IFindPackage, IInstallPackage,
$npmPackages = npm search $request.Name --json | ConvertFrom-Json

foreach ($item in $npmPackages) {
if ($request.IsMatch($item.name, $item.version)) {
$metadata = $item | ConvertTo-Metadata
$package = [PackageInfo]::new($item.name, $item.version, $null, $item.description, $null, $metadata, $request.ProviderInfo)
$request.WritePackage($package)
if ($request.IsMatch($item.name)) {
$config = npm config list registry -g --json | ConvertFrom-Json
$url = "{0}/{1}" -f $config.registry, $item.name
$packages = Invoke-WebRequest -Uri $url | Select-Object -ExpandProperty Content | ConvertFrom-Json | Select-Object -ExpandProperty versions
$versions = $packages | Get-Member -MemberType Properties | Select-Object -ExpandProperty Name

foreach ($version in $versions) {
if ($request.IsMatch([PackageVersion]$version)) {
$package = $packages.$version
$metadata = $package | ConvertTo-Metadata
$packageInfo = [PackageInfo]::new($package.name, $version, $null, $package.description, $null, $metadata, $request.ProviderInfo)
$request.WritePackage($packageInfo)
}
}
}
}
}
Expand Down
15 changes: 12 additions & 3 deletions test/Find-Package.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,19 @@ Describe Find-Package {
Find-Package -Name cspell-dict-powershell |
Should -Not -BeNullOrEmpty
}
}

Context 'with -Version parameter' {
It 'Explicit version' {
$package = Find-Package -Name cspell-dict-powershell -Version 1.0.1
$package.Name | Should -Be cspell-dict-powershell
$package.Version | Should -Be 1.0.1
}

It 'multiple names' {
Find-Package -Name cspell-dict-powershell, posh-gulp |
Should -HaveCount 2
It 'Version range' {
$range = [AnyPackage.Provider.PackageVersionRange]::new('[1.0, 1.0.5)')
Find-Package -Name cspell-dict-powershell -Version '[1.0, 1.0.5)' |
ForEach-Object { $range.Satisfies($_.Version) | Should -BeTrue }
}
}
}