ref #84735 allow cross-licence (same ext system) podcast asset attach…#133
Merged
Merged
Conversation
added 4 commits
June 29, 2026 13:03
…ment Relax PodcastEpisode.asset from same-licence to same-ext-system (reuse EqualExtSystem), relax PodcastLicenceFilter to ext-system, enforce the invariant at the factory chokepoint, authorize the new asset on episode update, and validate TTS synthesize podcasts by ext system.
eleven_v3 (and future models) reject previous_request_ids with HTTP 400. Only send the stitching ids for models on an explicit allowlist (ElevenlabsVoice::MODELS_WITH_REQUEST_STITCHING); unlisted models synthesize without stitching instead of failing.
Lift supportsRequestStitching() to the Voice base so the orchestrator skips the previous-request-id chain query for voices whose model does not stitch (eleven_v3, Google). Adds a functional test asserting eleven_v3 omits previous_request_ids while allowlisted models send them.
Reverts cdf4f5b: PodcastEpisode.asset back to same-licence (EqualLicence), PodcastLicenceFilter back to licence match, drop factory ext-system guard, episode-update auth, and TTS synthesize ext-system collection validation. Keeps the ElevenLabs model-allowlist stitching work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax PodcastEpisode.asset from same-licence to same-ext-system (reuse EqualExtSystem), relax PodcastLicenceFilter to ext-system, enforce the invariant at the factory chokepoint, authorize the new asset on episode update, and validate TTS synthesize podcasts by ext system.