IVY-1659: fix for NullPointerException

[eric-milles]

No description provided.

[maartenc]

Could you explain a bit more what this actually fixes ?

[eric-milles]

If, for example, name attribute is left off ibiblio element in ivysettings, there are setProperty calls that try to put null into the properties file. Everything else runs fine without this property, so treat put null as remove.

[maartenc]

The resolver name is used in some use-cases afterwards.
If I look at the documentation, it mentions that the name attribute on a resolver is mandatory.
Perhaps we should check this and throw some kind of validation error if this attribute isn't specified?

[eric-milles]

That may be worth a separate jira ticket. I ran into a situation where resolve failed for NPE on setProperty. Adding this to allow null to function as remove allowed resolve to proceed properly.

[eric-milles]

@maartenc I'd like to see my PRs get reviewed and merged. I'd be happy to take a look at some other issue tickets or something if that would help ease the burden. It did mention in some the my jira tickets that a PR would be easier to handle.

[maartenc]

Hi @eric-milles , yes, I will review all your PR's, many thanks for you contributions, it's greatly appriciated !! :-)
It takes some time, it's very busy at the moment... but I do my best to finish this before the end of august.

You could help a bit more and make the reviewing easier by not adding code-reformatting changes to it.
Having such unrelated changes makes it more difficult to review.

[eric-milles]

Sorry about some of the extra edits. The format is hard to work around, so there tend to be some minor cleanup as I work through an issue. Once this set of PRs gets in, the project settings will be refreshed and there will be less need to touch quite so many lines.