Skip to content

Update build tools#90

Open
twogee wants to merge 4 commits intoapache:masterfrom
twogee:java8
Open

Update build tools#90
twogee wants to merge 4 commits intoapache:masterfrom
twogee:java8

Conversation

@twogee
Copy link
Contributor

@twogee twogee commented Oct 30, 2019

Yay for Java 8!

@twogee twogee force-pushed the java8 branch 2 times, most recently from 581462f to 3a81358 Compare October 30, 2019 22:42
asfgit pushed a commit that referenced this pull request Nov 2, 2019
Contributed-by: Gintautas Grigelionis
Pull request: #90
asfgit pushed a commit that referenced this pull request Nov 2, 2019
Contributed-by: Gintautas Grigelionis
Pull request: #90
asfgit pushed a commit that referenced this pull request Nov 2, 2019
Contributed-by: Gintautas Grigelionis
Pull request: #90
asfgit pushed a commit that referenced this pull request Nov 2, 2019
Contributed-by: Gintautas Grigelionis
Pull request: #90
@twogee
Copy link
Contributor Author

twogee commented Nov 4, 2019

Looks like JDK must be updated in Jenkins...

@jaikiran
Copy link
Member

jaikiran commented Nov 5, 2019

retest this please

@bodewig
Copy link
Member

bodewig commented Feb 16, 2026

AFAICT Ivy still wants to be used with Java7

@twogee
Copy link
Contributor Author

twogee commented Feb 16, 2026

See 889bedb

@bodewig
Copy link
Member

bodewig commented Feb 16, 2026

See 889bedb

Thank you

@bodewig
Copy link
Member

bodewig commented Feb 16, 2026

Hmm, to me it looks as if the PR was about upgrading asciidoctor and switching from findbugs to spotbugs and not really about Java 8 at all.

@twogee
Copy link
Contributor Author

twogee commented Feb 16, 2026

I believe that's all what is left after Jaikiran cherrypicked some changes. Also, newer asciidoctor needs Java 8.
The latest asciidoctor is 2.0.26, and the latest japicmp is 0.25.4

BTW, PR #57 needs Java 8, too, but I'd have to clean it up.

@bodewig
Copy link
Member

bodewig commented Feb 16, 2026

I believe that's all what is left after Jaikiran cherrypicked some changes. Also, newer asciidoctor needs Java 8. The latest asciidoctor is 2.0.26, and the latest japicmp is 0.25.4

None of the changes is required by switching to Java 8, obviously. :-)

The checkstyle change changes rules (activates a rule about LineLength that used to be inactive, adds a SuppressComments module). I don't think we should do this "under the radar", if at all.

BTW, PR #57 needs Java 8, too, but I'd have to clean it up.

Given the discussion inside #57 I don't plan to spend time reviewing it.

@twogee twogee changed the title Java 8 Update build tools Feb 16, 2026
@twogee
Copy link
Contributor Author

twogee commented Feb 16, 2026

Thanks for reviewing. I will check if newer versions of Checkstyle require rule changes and resubmit, if you still consider the PR relevant.

@bodewig
Copy link
Member

bodewig commented Feb 16, 2026

I'm fine with updating tools and adjusting, as long as we don't change what the tools do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants