Conversation
581462f to
3a81358
Compare
Contributed-by: Gintautas Grigelionis Pull request: #90
Contributed-by: Gintautas Grigelionis Pull request: #90
Contributed-by: Gintautas Grigelionis Pull request: #90
Contributed-by: Gintautas Grigelionis Pull request: #90
|
Looks like JDK must be updated in Jenkins... |
|
retest this please |
|
AFAICT Ivy still wants to be used with Java7 |
|
See 889bedb |
Thank you |
|
Hmm, to me it looks as if the PR was about upgrading asciidoctor and switching from findbugs to spotbugs and not really about Java 8 at all. |
|
I believe that's all what is left after Jaikiran cherrypicked some changes. Also, newer asciidoctor needs Java 8. BTW, PR #57 needs Java 8, too, but I'd have to clean it up. |
None of the changes is required by switching to Java 8, obviously. :-) The checkstyle change changes rules (activates a rule about LineLength that used to be inactive, adds a SuppressComments module). I don't think we should do this "under the radar", if at all.
Given the discussion inside #57 I don't plan to spend time reviewing it. |
|
Thanks for reviewing. I will check if newer versions of Checkstyle require rule changes and resubmit, if you still consider the PR relevant. |
|
I'm fine with updating tools and adjusting, as long as we don't change what the tools do. |
Yay for Java 8!