fix: toggle theme switch appearing on the website pages#1978
Open
ayush00git wants to merge 1 commit intoapache:masterfrom
Open
fix: toggle theme switch appearing on the website pages#1978ayush00git wants to merge 1 commit intoapache:masterfrom
ayush00git wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Hey @yzeng25 can you please review the PR, and please let me know if there are any changes. |
Contributor
Author
|
Hey @SkyeYoung @Baoyuantop |
Contributor
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1977
Changes:
Removed the desktop rule that hid
.react-toggleinwebsite/src/css/customTheme.scss, so the theme switch is now visible in the navbar on all pages.Removed
ThemeResetComponentfromwebsite/src/pages/index.tsx, which previously forced light mode and manually hid the toggle via DOM queries. The component was forcing light theme whenever the home page was being opened.Result:
The color mode switch now appears and works consistently across the whole website, matching the behavior of the Blog and Case Studies page.
Screenshots of the change: