Docs: Add additional documentation and example for make_array#9112
Merged
Jefffrey merged 1 commit intoapache:mainfrom Jan 10, 2026
Merged
Docs: Add additional documentation and example for make_array#9112Jefffrey merged 1 commit intoapache:mainfrom
make_array#9112Jefffrey merged 1 commit intoapache:mainfrom
Conversation
alamb
commented
Jan 7, 2026
| /// // Create the ArrayRef from the ArrayData | ||
| /// let array = make_array(array_data); | ||
| /// | ||
| /// // It is equivalent to directly constructing the Int32Array |
Contributor
Author
There was a problem hiding this comment.
I think it is important to also add an example of what "directly constructing the array" means
Closed
1 task
mhilton
approved these changes
Jan 9, 2026
Jefffrey
approved these changes
Jan 10, 2026
Contributor
|
Nice addition 👍 |
Contributor
Author
|
Thanks @Jefffrey |
Dandandan
pushed a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jan 15, 2026
…he#9112) # Which issue does this PR close? - Part of apache#9061 # Rationale for this change @tustvold says apache#9058 (comment) > My 2 cents is it would be better to move the codepaths relying on ArrayData over to using the typed arrays directly, this should not only cut down on allocations but unnecessary validation and dispatch overheads. Let's make sure the documentation also encodes this wisdom # What changes are included in this PR? Improve the documentation for `make_array` to include the information about `make_array` # Are these changes tested? By CI # Are there any user-facing changes? Only docs and an example, no functional changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
make_array) #9061Rationale for this change
@tustvold says #9058 (comment)
Let's make sure the documentation also encodes this wisdom
What changes are included in this PR?
Improve the documentation for
make_arrayto include the information aboutmake_arrayAre these changes tested?
By CI
Are there any user-facing changes?
Only docs and an example, no functional changes