Skip to content

Move Row Filter tests to a separate module#9335

Merged
alamb merged 1 commit intoapache:mainfrom
sdf-jkl:split-tests1
Feb 3, 2026
Merged

Move Row Filter tests to a separate module#9335
alamb merged 1 commit intoapache:mainfrom
sdf-jkl:split-tests1

Conversation

@sdf-jkl
Copy link
Contributor

@sdf-jkl sdf-jkl commented Feb 2, 2026

Which issue does this PR close?

Rationale for this change

Check issue

What changes are included in this PR?

Moved tests created in #8733 to a separate module -> parquet/tests/arrow_reader/row_filter.rs

Are these changes tested?

No need, code movement.

Are there any user-facing changes?

No, code movement.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Feb 2, 2026
@sdf-jkl sdf-jkl marked this pull request as ready for review February 3, 2026 16:41
@sdf-jkl sdf-jkl changed the title Move adaptive predicate pushdown test to a separate module Move row_filter tests to a separate module Feb 3, 2026
@sdf-jkl sdf-jkl changed the title Move row_filter tests to a separate module Move Row Filter tests to a separate module Feb 3, 2026
@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Feb 3, 2026

@alamb ready for review.

@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Feb 3, 2026

I am also thinking about doing the same to the async tests.

An idea I have is to create a folder for each topic(i.e. row_filter/) and have mod.rs, sync.rs and async.rs inside to split the dependencies.

@alamb
Copy link
Contributor

alamb commented Feb 3, 2026

An idea I have is to create a folder for each topic(i.e. row_filter/) and have mod.rs, sync.rs and async.rs inside to split the dependencies.

That sounds like a good idea to me

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sdf-jkl -- since this is just code movement I will merge it quickly to keep the code flowing

@alamb alamb merged commit 66abc6c into apache:main Feb 3, 2026
32 of 33 checks passed
@alamb alamb added the development-process Related to development process of arrow-rs label Feb 3, 2026
@sdf-jkl sdf-jkl deleted the split-tests1 branch February 5, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of arrow-rs parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants