-
Notifications
You must be signed in to change notification settings - Fork 122
Announce Arrow security model #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview URL: https://pitrou.github.io/arrow-site If the preview URL doesn't work, you may forget to configure your fork repository for preview. |
448ff93 to
c3e008c
Compare
c3e008c to
c3db7b6
Compare
|
@alamb @amoeba @paleolimbot Thoughts about this? |
|
Also cc @raboof |
amoeba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I had a few editorial comments.
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pitrou -- I have some minor wording suggestions, but none of them are required in my mind. This is a very nice addition
Thank you for all your work in this area
| date: "2023-11-09 00:00:00" | ||
| author: pmc | ||
| categories: [release] | ||
| categories: [release, security] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the rationale for this to be marked with security related to the fact that this release was only a security fix?
This release contains a single security fix for PyArrow. Other implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not answering earlier. Yes, that is the rationale. I don't know if that is a good idea as we have not been announcing security fixes consistently on the blog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, we can remove this keyword later so it should probably not block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree -- if it turns out to be a problem we can remove the keyword
security.md
Outdated
|
|
||
| First, please carefully read the Apache Arrow | ||
| [Security Model](https://arrow.apache.org/docs/dev/format/Security.html) | ||
| and understand its implications, as some apparent security issues can actually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense here to explicitly list untrusted sources as I think that is the core potential attack vector that has been highlighted several times
Something like
| and understand its implications, as some apparent security issues can actually | |
| and understand its implications for untrusted data sources, as some apparent security issues can actually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, that seems like a good idea.
| @@ -0,0 +1,46 @@ | |||
| --- | |||
| layout: post | |||
| title: "Introducing a Security Model for Arrow" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon reflection, I am not sure what we have written is really a security "model" , in that it doesn't seem to be a formal scheme for applying security policies. I would say what we have written is more like "Security Best Practices" or a Trust Model (aka what should be trusted)
perhaps @raboof could help us here with the correct terminology for this concept (maybe it is Security Model)
Also, perhaps we should emphasize we are not (really) introducing a new model, instead in my mind we have instead formalized what was previously implicit. Perhaps a title such as
"Introducing Security Best Practices for Apache Arrow"
Would emphasize this better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we have here is more like how the ASF defines it rather than what Wikipedia makes it sound like. I don't have any issues with the current language but also have no experience in this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks -- that is a good reference. I agree per the ASF definition we have defined a security model and thus the current PR content / title is good
paleolimbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a read through and the text is great. Thank you for working on this!
|
Thanks again for getting this published @pitrou |
|
The blog is live here in case anyone is looking for it: https://arrow.apache.org/blog/2026/02/09/arrow-security-model/ |
Uh oh!
There was an error while loading. Please reload this page.