Skip to content

Conversation

@pabloem
Copy link
Member

@pabloem pabloem commented Dec 26, 2025

@ksobrenat32 - is this correct? looks like only beam_writer failed.

fyi @yalah5084 the previous change did not add the privileges so I'm trying to fix it here.

@ksobrenat32 - is this correct? looks like only `beam_writer` failed.

fyi @yalah5084 the previous change did not add the privileges so I'm trying to fix it here.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @pabloem, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where a previous attempt to assign privileges failed due to an incorrectly formatted role label. By modifying the beam_writer role definition within the users.yml configuration, this change ensures that the intended permissions are now correctly recognized and applied, resolving the privilege assignment problem.

Highlights

  • Role Label Correction: The beam_writer role label in infra/iam/users.yml was updated from beam_writer to roles/beam_writer to ensure proper privilege assignment, addressing a previous failure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Terraform Plan for User Roles Changes


Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # google_project_iam_member.project_members["yalahuangfeng@gmail.com-roles/beam_writer"] will be created
  + resource "google_project_iam_member" "project_members" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = "user:yalahuangfeng@gmail.com"
      + project = "apache-beam-testing"
      + role    = "roles/beam_writer"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @jrmccluskey added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant