-
Notifications
You must be signed in to change notification settings - Fork 119
Add settings to mark cryptographic algorithms in vpn customer gateways as excluded or obsolete #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
|
@blueorangutan docbuild |
|
@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/605. (QA-JID 466) |
| warning message encouraging users to change it to a more secure | ||
| alternative. | ||
|
|
||
| - The ``listVpnCustomerGateways`` API response includes two new boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abh1sar - I think the list vpncustomergateways API response fields are a list of strings, not boolean.
- In the actual API response, the field names are
obsoleteparametersandexcludedparameters - Field type is string, not boolean
- Fields contain the actual parameter list, e.g., "[sha1, 3des]"
Can we please update this in the docs to match the actual implementation?
(testuser) 🐱 > list vpncustomergateways keyword=test-both
{
"count": 1,
"vpncustomergateway": [
{
"account": "testuser",
"cidrlist": "0.0.0.0/0",
"domain": "TestDomain",
"domainid": "0fb6c46d-1d16-48b4-b146-9234ec22e63e",
"domainpath": "ROOT/TestDomain",
"dpd": false,
"esplifetime": 3600,
"esppolicy": "aes256-sha256",
"excludedparameters": "[3des]",
"forceencap": false,
"gateway": "10.1.1.8",
"hasannotations": false,
"id": "89bf9794-f457-4cb9-b617-da93f268eb12",
"ikelifetime": 86400,
"ikepolicy": "3des-sha1;modp2048",
"ikeversion": "ikev2",
"ipsecpsk": "test123",
"name": "test-both",
"obsoleteparameters": "[sha1]",
"splitconnections": false
}
]
}
RosiKyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhisar, I've added some comments, could you please check them?
|
@blueorangutan docbuild |
|
@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/605. (QA-JID 468) |
RosiKyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@blueorangutan docbuild |
|
@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/605. (QA-JID 469) |
Doc PR for apache/cloudstack#12193
📚 Documentation preview 📚: https://cloudstack-documentation--605.org.readthedocs.build/en/605/