server: trim autoscale Windows VM hostname #11327

shwstppr · 2025-07-29T10:16:01Z

Description

Fixes #9505

Trim the generated hostname for Windows VM to 15 characters.
Doc PR: apache/cloudstack-documentation#575

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-07-29T10:23:54Z

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (ac8c200) to head (d2544d4).
⚠️ Report is 66 commits behind head on main.

Files with missing lines	Patch %	Lines
...ava/com/cloud/network/as/AutoScaleManagerImpl.java	90.47%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11327   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
+ Complexity    15544    15543    -1     
=========================================
  Files          5909     5909           
  Lines        529059   529074   +15     
  Branches      64617    64620    +3     
=========================================
+ Hits          92941    92944    +3     
- Misses       425664   425675   +11     
- Partials      10454    10455    +1

Flag	Coverage Δ
uitests	`3.58% <ø> (ø)`
unittests	`18.63% <90.47%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr · 2025-07-30T06:22:40Z

@blueorangutan package

blueorangutan · 2025-07-30T06:24:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-30T08:56:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14463

github-actions · 2025-07-31T11:58:30Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache · 2025-08-25T10:47:55Z

@shwstppr
is this ready for review ?

shwstppr · 2025-08-25T11:02:10Z

@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same.

weizhouapache · 2025-08-25T11:18:31Z

@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same.

@shwstppr
looks ok to me. I could not find a better solution to be honest.

is it possible the first letter is unaccepted (for example -) after the truncation ?

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

shwstppr · 2025-08-26T04:52:44Z

@blueorangutan package

blueorangutan · 2025-08-26T04:54:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-26T06:53:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14730

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

shwstppr · 2025-09-10T04:10:55Z

@blueorangutan package

blueorangutan · 2025-09-10T04:12:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-10T05:54:08Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14929

weizhouapache

code lgtm

DaanHoogland · 2025-09-15T08:12:51Z

@blueorangutan test

DaanHoogland

clgtm

abh1sar · 2025-09-30T10:44:40Z

@shwstppr I am getting this NPE with a Windows10 qcow2 template. Not sure if I did something wrong.
I have a mixed kvm, vmware env.

shwstppr · 2025-09-30T13:26:32Z

@blueorangutan package

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

weizhouapache · 2025-11-07T09:19:55Z

discussed with @shwstppr , I made some changes on this PR on the name convention of autoscale Windows VM

now the vm name and display name look like

the last 6 letters are the same in the two names. they are generated by RandomStringUtils.random

weizhouapache · 2025-11-07T09:20:07Z

@blueorangutan package

blueorangutan · 2025-11-07T09:22:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-07T11:08:55Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15675

RosiKyu · 2025-12-10T19:57:04Z

@blueorangutan package

blueorangutan · 2025-12-10T19:58:04Z

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-10T21:44:15Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15990

blueorangutan · 2025-12-11T09:57:18Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16003

RosiKyu · 2025-12-12T09:15:43Z

@blueorangutan package

blueorangutan · 2025-12-12T09:18:04Z

@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-12T11:16:59Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16020

blueorangutan · 2025-12-12T14:26:23Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16027

RosiKyu · 2025-12-12T20:23:39Z

@blueorangutan package

blueorangutan · 2025-12-12T20:24:06Z

@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-12T21:22:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16033

RosiKyu

LGTM

Test Case Expected Actual Status

Windows hostname ≤ 15 chars as-WinVm-xxxxxx as-WinVm-cifpcf PASS

Windows displayname full autoScaleVm-...-1-xxxxxx autoScaleVm-windows-autoscale-test-1-cifpcf PASS

Linux name = displayname Same value Both autoScaleVm-linux-autoscale-test-1-pjudpx PASS

No regression for Linux Full hostname format Full hostname format PASS

Windows VMs

(localcloud) 🐱 > list virtualmachines listall=true keyword=as-WinVm filter=id,name,displayname,state
{
  "count": 3,
  "virtualmachine": [
    {
      "displayname": "autoScaleVm-windows-autoscale-test-1-cifpcf",
      "id": "b13dd0d8-b424-4d55-979a-797b7cf5040c",
      "name": "as-WinVm-cifpcf",
      "state": "Running"
    },
    {
      "displayname": "autoScaleVm-windows-autoscale-test-2-xgvxsl",
      "id": "0eca7403-7ca9-498f-9eda-7582bb179d6f",
      "name": "as-WinVm-xgvxsl",
      "state": "Running"
    },
    {
      "displayname": "autoScaleVm-windows-autoscale-test-3-cacjld",
      "id": "966ea9c0-a16b-4ff8-9bb6-323660814f95",
      "name": "as-WinVm-cacjld",
      "state": "Running"
    }
  ]
}

Linux VMs

(localcloud) 🐱 > list virtualmachines listall=true keyword=autoScaleVm-linux filter=id,name,displayname,state
{
  "count": 1,
  "virtualmachine": [
    {
      "displayname": "autoScaleVm-linux-autoscale-test-1-pjudpx",
      "id": "24a59eb9-d874-4717-aed0-ecda7ecca4b6",
      "name": "autoScaleVm-linux-autoscale-test-1-pjudpx",
      "state": "Running"
    }
  ]
}

DB Evidence

mysql> SELECT 
    ->     v.id,
    ->     v.instance_name,
    ->     v.name AS hostname,
    ->     v.display_name,
    ->     v.state,
    ->     g.display_name AS guest_os
    -> FROM vm_instance v
    -> LEFT JOIN guest_os g ON v.guest_os_id = g.id
    -> WHERE v.display_name LIKE 'autoScaleVm%'
    -> ORDER BY v.created DESC;
+----+---------------+-------------------------------------------+---------------------------------------------+---------+------------------------------+
| id | instance_name | hostname                                  | display_name                                | state   | guest_os                     |
+----+---------------+-------------------------------------------+---------------------------------------------+---------+------------------------------+
|  8 | i-2-8-VM      | autoScaleVm-linux-autoscale-test-1-pjudpx | autoScaleVm-linux-autoscale-test-1-pjudpx   | Running | CentOS 5.5 (64-bit)          |
|  7 | i-2-7-VM      | as-WinVm-cacjld                           | autoScaleVm-windows-autoscale-test-3-cacjld | Running | Windows Server 2019 (64-bit) |
|  6 | i-2-6-VM      | as-WinVm-xgvxsl                           | autoScaleVm-windows-autoscale-test-2-xgvxsl | Running | Windows Server 2019 (64-bit) |
|  5 | i-2-5-VM      | as-WinVm-cifpcf                           | autoScaleVm-windows-autoscale-test-1-cifpcf | Running | Windows Server 2019 (64-bit) |
+----+---------------+-------------------------------------------+---------------------------------------------+---------+------------------------------+
4 rows in set (0.00 sec)

UI Evidence

boring-cyborg bot added the component:networking label Jul 29, 2025

github-actions bot added the status:has-conflicts label Jul 31, 2025

github-actions bot removed the status:has-conflicts label Aug 1, 2025

shwstppr marked this pull request as ready for review August 25, 2025 11:02

DaanHoogland reviewed Aug 25, 2025

View reviewed changes

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Outdated Show resolved Hide resolved

weizhouapache reviewed Aug 26, 2025

View reviewed changes

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Outdated Show resolved Hide resolved

harikrishna-patnala added this to the 4.22.0 milestone Sep 3, 2025

harikrishna-patnala added this to Apache CloudStack 4.22.0 Sep 3, 2025

harikrishna-patnala moved this to In Progress in Apache CloudStack 4.22.0 Sep 3, 2025

weizhouapache approved these changes Sep 10, 2025

View reviewed changes

DaanHoogland approved these changes Sep 15, 2025

View reviewed changes

apache deleted a comment from blueorangutan Sep 30, 2025

shwstppr and others added 6 commits November 6, 2025 20:49

address comment

9fe7062

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix

64a7a1c

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

missing test change

af7fd5d

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

avoid chances of npe if both guestos name and displayname are null

0e9fd67

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

change

6d28bd2

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

as: simplify windows vm name

d2544d4

weizhouapache reopened this Nov 7, 2025

weizhouapache force-pushed the fix-autoscalewinvm branch from d24ffc3 to d2544d4 Compare November 7, 2025 09:17

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

RosiKyu self-assigned this Dec 10, 2025

RosiKyu approved these changes Dec 15, 2025

View reviewed changes

RosiKyu added the status:ready-for-merge label Dec 15, 2025

DaanHoogland merged commit da1c7ce into apache:main Dec 15, 2025
28 checks passed

DaanHoogland deleted the fix-autoscalewinvm branch December 15, 2025 14:52

DaanHoogland added this to the 4.23.0 milestone Dec 18, 2025

Test Case	Expected	Actual	Status
Windows hostname ≤ 15 chars	as-WinVm-xxxxxx	as-WinVm-cifpcf	PASS
Windows displayname full	autoScaleVm-...-1-xxxxxx	autoScaleVm-windows-autoscale-test-1-cifpcf	PASS
Linux name = displayname	Same value	Both autoScaleVm-linux-autoscale-test-1-pjudpx	PASS
No regression for Linux	Full hostname format	Full hostname format	PASS

server: trim autoscale Windows VM hostname #11327

server: trim autoscale Windows VM hostname #11327

Uh oh!

Conversation

shwstppr commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

shwstppr commented Aug 25, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

Uh oh!

shwstppr commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

Uh oh!

shwstppr commented Sep 10, 2025

Uh oh!

blueorangutan commented Sep 10, 2025

Uh oh!

blueorangutan commented Sep 10, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Sep 15, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

abh1sar commented Sep 30, 2025

Uh oh!

shwstppr commented Sep 30, 2025

Uh oh!

weizhouapache commented Nov 7, 2025

Uh oh!

weizhouapache commented Nov 7, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

RosiKyu commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 11, 2025

Uh oh!

RosiKyu commented Dec 12, 2025

Uh oh!

blueorangutan commented Dec 12, 2025

Uh oh!

blueorangutan commented Dec 12, 2025

shwstppr commented Jul 29, 2025 •

edited

Loading

codecov bot commented Jul 29, 2025 •

edited

Loading