Improve message "Network is unavailable. Please contact administrator"

[daviftorres]

Description

This trivial change provide more details for root administrators during troubleshooting.

See discussion #11980

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

clgtm

[codecov]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.46%. Comparing base (f570e16) to head (8807fd9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11981      +/-   ##
============================================
- Coverage     17.46%   17.46%   -0.01%     
+ Complexity    15516    15514       -2     
============================================
  Files          5913     5913              
  Lines        529385   529389       +4     
  Branches      64679    64680       +1     
============================================
  Hits          92450    92450              
- Misses       426517   426521       +4     
  Partials      10418    10418              

Flag	Coverage Δ
uitests	3.58% <ø> (ø)
unittests	18.52% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

not sure if this makes sense, but type breaks as it expects a throwable.

[DaanHoogland]

clgtm

[nvazquez]

Thanks @daviftorres - just a comment from my review

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15819

[DaanHoogland]

sorry if I have been misleading you @daviftorres , but callingUser needs first be defined. It is not available in the method as we speak :/ This might not be possible with the available context, hence the “needs testing” note.

@nvazquez , any idea how to implement your requirement from #11981 (comment) in this asynchronous context?

[nvazquez]

Hi @daviftorres I have pushed a fix to your branch/PR to address the comment. I have also reverted the 'Guest Network' text for just 'Network' as the VM starting may also be a system VM or a VR. cc. @DaanHoogland

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15820

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14861)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 48530 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11981-t14861-kvm-ol8.zip
Smoke tests completed. 150 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[nvazquez]

LGTM