Skip to content

Conversation

@harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Nov 13, 2025

Description

This PR is trying to address the issue mentioned in #10665

Added few safe checks and operations accordingly to make sure configuration is of log4j format.

I've also added a document PR which adds a notes to check the log4j2 format before upgrade apache/cloudstack-documentation#604

If there is any risk with the changes in this PR, I'm happy to only go with the document change

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15741

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14871)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 48385 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12061-t14871-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@harikrishna-patnala
Copy link
Contributor Author

I've also added a document PR which adds a notes to check the log4j2 format before upgrade apache/cloudstack-documentation#604

If there is any risk with the changes in this PR, I'm happy to only go with the document change

cc @DaanHoogland @Pearl1594 @weizhouapache @sureshanaparti

@harikrishna-patnala harikrishna-patnala marked this pull request as ready for review December 4, 2025 09:43
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harikrishna-patnala Is this solution only for debian?

@harikrishna-patnala
Copy link
Contributor Author

Thanks for the review @Pearl1594 and @DaanHoogland . I'm closing the PR in favor of the document PR (apache/cloudstack-documentation#604) which seems to be enough as this behavior is expected

@DaanHoogland DaanHoogland deleted the log4j-safe-checks branch December 10, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically migrate log4j xml from 4.19 to 4.20+

4 participants