Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 71 commits into
base: main
Choose a base branch
from
+12,091 −207

add proper support for resizing of clvm_ng which calculated PE correc…

40364da
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

add proper support for resizing of clvm_ng which calculated PE correc…
40364da
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 15, 2026 in 5m 11s

Quality Gate failed

Failed conditions
1 Security Hotspot
33.5% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1332 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace charset name argument with StandardCharsets.UTF_8 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1hd&open=AZ4Ig9UJLLXNfHHEi1hd&pullRequest=12617

Check warning on line 2042 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1hR&open=AZ4Ig9UJLLXNfHHEi1hR&pullRequest=12617

Check failure on line 260 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9a_LLXNfHHEi1h9&open=AZ4Ig9a_LLXNfHHEi1h9&pullRequest=12617

Check warning on line 115 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "getClvmLockHostId"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9f_LLXNfHHEi1i1&open=AZ4Ig9f_LLXNfHHEi1i1&pullRequest=12617

Check failure on line 36 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtClvmLockTransferCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"logger" is the name of a field in "CommandWrapper". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9NWLLXNfHHEi1gh&open=AZ4Ig9NWLLXNfHHEi1gh&pullRequest=12617

Check warning on line 7189 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "details" which hides the field declared at line 260. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9YwLLXNfHHEi1hy&open=AZ4Ig9YwLLXNfHHEi1hy&pullRequest=12617

Check warning on line 56 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPrepareForMigrationCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 83 to 64, Complexity from 20 to 14, Nesting Level from 5 to 2, Number of Variables from 22 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9OjLLXNfHHEi1go&open=AZ4Ig9OjLLXNfHHEi1go&pullRequest=12617

Check warning on line 66 in engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeServiceImplClvmTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_hostDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9AzLLXNfHHEi1gD&open=AZ4Ig9AzLLXNfHHEi1gD&pullRequest=12617

Check warning on line 378 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9hlLLXNfHHEi1i-&open=AZ4Ig9hlLLXNfHHEi1i-&pullRequest=12617

Check warning on line 527 in server/src/test/java/com/cloud/storage/ClvmPoolManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9nQLLXNfHHEi1jP&open=AZ4Ig9nQLLXNfHHEi1jP&pullRequest=12617

Check warning on line 318 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1g9&open=AZ4Ig9SkLLXNfHHEi1g9&pullRequest=12617

Check failure on line 368 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1iJ&open=AZ4Ig9bNLLXNfHHEi1iJ&pullRequest=12617

Check warning on line 398 in engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeServiceImplClvmTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9AzLLXNfHHEi1gE&open=AZ4Ig9AzLLXNfHHEi1gE&pullRequest=12617

Check failure on line 273 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--noheadings" 8 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1gw&open=AZ4Ig9SkLLXNfHHEi1gw&pullRequest=12617

Check failure on line 837 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1ia&open=AZ4Ig9bNLLXNfHHEi1ia&pullRequest=12617

Check failure on line 470 in plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/driver/CloudStackPrimaryDataStoreDriverImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 28 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4pg0nfI-vGf32cl18Z&open=AZ4pg0nfI-vGf32cl18Z&pullRequest=12617

Check warning on line 32 in core/src/main/java/org/apache/cloudstack/storage/clvm/command/ClvmLockTransferCommand.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Override the "equals" method in this class. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9MnLLXNfHHEi1gf&open=AZ4Ig9MnLLXNfHHEi1gf&pullRequest=12617

Check warning on line 283 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_agentMgr" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9DRLLXNfHHEi1gP&open=AZ4Ig9DRLLXNfHHEi1gP&pullRequest=12617

Check failure on line 2994 in engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig8_7LLXNfHHEi1gC&open=AZ4Ig8_7LLXNfHHEi1gC&pullRequest=12617

Check warning on line 460 in engine/storage/volume/src/test/java/org/apache/cloudstack/storage/volume/VolumeServiceImplClvmTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9AzLLXNfHHEi1gI&open=AZ4Ig9AzLLXNfHHEi1gI&pullRequest=12617

Check failure on line 786 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9bNLLXNfHHEi1iX&open=AZ4Ig9bNLLXNfHHEi1iX&pullRequest=12617

Check warning on line 176 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostMigrationCommandWrapperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.libvirt.LibvirtException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9XgLLXNfHHEi1hr&open=AZ4Ig9XgLLXNfHHEi1hr&pullRequest=12617

Check warning on line 2278 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig88pLLXNfHHEi1f7&open=AZ4Ig88pLLXNfHHEi1f7&pullRequest=12617

Check warning on line 1162 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9UJLLXNfHHEi1hS&open=AZ4Ig9UJLLXNfHHEi1hS&pullRequest=12617

Check warning on line 83 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig83DLLXNfHHEi1fy&open=AZ4Ig83DLLXNfHHEi1fy&pullRequest=12617
View more details on SonarQubeCloud