Add more details to VM deployment failure alert messages

[GaOrtiga]

Description

This PR improves the details provided in the logs and in the alert email sent when a VM fails to deploy.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[Copilot]

Pull request overview

This PR enhances VM deployment failure diagnostics by improving the log lines and the alert email content generated when VM creation fails, aiming to make troubleshooting easier.

Changes:

• Refines log messages during failed VM deployment cleanup (VM/volume destruction path).
• Updates the VM deployment failure alert to use a dedicated subject/body and include a log context id reference.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.00%. Comparing base (5d61ba3) to head (d17a813).
⚠️ Report is 128 commits behind head on main.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12939      +/-   ##
============================================
- Coverage     18.02%   18.00%   -0.02%     
+ Complexity    16466    16459       -7     
============================================
  Files          5973     5976       +3     
  Lines        537466   537587     +121     
  Branches      65991    66007      +16     
============================================
- Hits          96855    96802      -53     
- Misses       429689   429873     +184     
+ Partials      10922    10912      -10     

Flag	Coverage Δ
uitests	3.52% <ø> (ø)
unittests	19.17% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17321

[erikbocks]

Just a minor regard
CLGTM

[weizhouapache]

@GaOrtiga
Have you considered introducing a global correlation ID that can be propagated across all components, for example, API request/response logs, async jobs, and agent processing ?

I think it would make troubleshooting and tracing workflows much easier.

[GaOrtiga]

@GaOrtiga Have you considered introducing a global correlation ID that can be propagated across all components, for example, API request/response logs, async jobs, and agent processing ?

I think it would make troubleshooting and tracing workflows much easier.

Hello, @weizhouapache

That does sound interesting; anything that improves troubleshooting is always welcome when it comes to complex environments such as the ones orchestrated by ACS.

I'm afraid it falls out of the scope of this PR, though, but if anyone is interested in picking up and implementing this idea, I think it would be a good enhancement for the platform.