Make domainid optional in assignVirtualMachine#13213
Open
winterhazel wants to merge 1 commit into
Open
Conversation
winterhazel
force-pushed
the
adjust-assignvmcmd-parameters
branch
from
567abaf to
e56e97a
Compare
boring-cyborg
Bot
added
component:build
component:database
component:integration-test
component:integration
component:marvin
component:networking
component:packaging
component:primary-storage
component:storage
component:systemd
component:UI
component:usage-server
distro:centos
distro:ubuntu
docker
Python
winterhazel
removed
component:primary-storage
component:packaging
component:systemd
component:usage-server
component:networking
component:UI
Python
Member
Author
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17973 |
Member
Author
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17974 |
Contributor
@winterhazel , I think we are hitting one of our limits here. I’ll try some more in the backend. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17984 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
assignVirtualMachinedemands providing adomainid, even though there are situations in which it is not required, such as when moving an instance to a project usingprojectid. This patch removes this restriction.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
projectidandvirtualmachineidparametersaccount,domainid, andvirtualmachineidparametersprojectidanddomainidare provided,domainidis ignored and the VM is moved to the project