Project drop-down refresh data fix#2810
Merged
Merged
Conversation
Contributor
Author
|
@houthuis @dhlaluku @rhtyd @rafaelweingartner , please review. |
Contributor
|
@blueorangutan package |
|
@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2255 |
dhlaluku
approved these changes
Aug 17, 2018
Contributor
dhlaluku
left a comment
There was a problem hiding this comment.
LGTM, I have tested manually and I confirm that the functionality of this change adheres to the description.
yadvr
approved these changes
Aug 17, 2018
DaanHoogland
pushed a commit
that referenced
this pull request
Aug 20, 2018
* 4.11: populate project select when clicked on to display latest project options (#2810)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the UI, the 'Project' drop-down displays all the projects that the logged in user is a member of.
A regular user can add other accounts to a project when creating the project.
An Admin user can also add other accounts to an existing project.
When user 'x' adds account 'y' to a project 'z' and user 'y' is logged in to another session at the same time, the 'Project' drop-down in user 'y' session does not display project 'z' to which he/she has just been added as a member in the other session.
The latest project addition will only display in the drop-down if the user refreshes the HTML page.
Expected Behaviour:
Whenever user 'y' clicks on the drop-down to display the projects, it must include the newly added project 'z' without having to refresh the HTML page.
Whenever a user clicks on the 'Project' drop-down to display the projects he/she is a member of, Cloudstack must fetch the latest projects data from the database and repopulate the drop-down so that it displays all the up-to-date projects including projects that this user has been added to in other user sessions.
Current Behaviour:
Whenever user 'y' clicks on the drop-down to display the projects, it does not include the newly added project 'z' unless the HTML page is refreshed.
To Reproduce:
In the UI, log in as an Admin User. While logged in as an Admin User, also log in to another session as a different user.
Go back to the Admin User session and on the lefthand side, select the Projects link.
Create a new project or select an existing project. Add to the project the account belonging to the user that you used to log in to the other session.
After adding the account to the project in the Admin User session, go back to the added account user's session and click on the 'Project' drop-down in the top left corner. The drop-down will display all the projects that the user is a part of, except the project that he/she has just been added to in the Admin user's session.
Types of changes
GitHub Issue/PRs
Screenshots (if appropriate):
How Has This Been Tested?
Manually (See screenshots above):
In the UI, log in as an Admin User. While logged in as an Admin User, also log in to another session as a different user.
Go back to the Admin User session and on the lefthand side, select the Projects link.
Create a new project or select an existing project. Add to the project the account belonging to the user that you used to log in to the other session.
After adding the account to the project in the Admin User session, go back to the added account user's session and click on the 'Project' drop-down in the top left corner. The drop-down will now display all the projects that the user is a part including the project that he/she has just been added to in the Admin user's session.
CloudStack version 4.11, KVM hypervisor.
Checklist:
Testing