Skip to content

Fix set initial reservation on public IP ranges#2981

Closed
nvazquez wants to merge 1 commit into
apache:masterfrom
shapeblue:iprangedomainuifix-master
Closed

Fix set initial reservation on public IP ranges#2981
nvazquez wants to merge 1 commit into
apache:masterfrom
shapeblue:iprangedomainuifix-master

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

Description

Fix initial reservation on public IP range addition. Also, if the range is dedicated for system VMs do not allow dedicating it to any account

Fixes: #2929

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

  • Set reservation to a domain, add range. Verify domain is set to the domain.

@nvazquez
Copy link
Copy Markdown
Contributor Author

Hi @svenvogel can you please test it?

@svenvogel
Copy link
Copy Markdown
Contributor

Hi @nvazquez wow great.. i will test fastly and done back greets Sven

@DaanHoogland
Copy link
Copy Markdown
Contributor

#2980 fixes this for 4.11. we should not merge this as it will be merged forward from there.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Oct 30, 2018

If there is already a 4.11 based PR, this can be closed @nvazquez

@nvazquez
Copy link
Copy Markdown
Contributor Author

@rhtyd @DaanHoogland yes, just created this PR for testing it on master. Closing it

@nvazquez nvazquez closed this Oct 31, 2018
@nvazquez nvazquez deleted the iprangedomainuifix-master branch April 6, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add public IP range to domain fails in the inital setup (UI Problem)

4 participants