Fix DirectNetworkGuru canHandle checks for lowercase isolation methods

[nvazquez]

Description

Fixes: #2989

In upgrade to 4.11 RC4 from 4.9.3 it was found that Shared networks could not be created after the upgrade, failing with:

The DirectNetworkGuru refused to design the network due to the isolation method from the physical network was "vlan" and the guru expected "VLAN"

2018-11-06 16:21:37,396 TRACE [c.c.n.g.DirectNetworkGuru] (qtp1096283470-28:ctx-bdc0f3b5 ctx-dacb5ddd) (logid:f3094acc) We only take care of Guest networks of type Shared

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

[nvazquez]

Hi @somejfn can you please test this fix and retry your tests?

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2410

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3146)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28327 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3010-t3146-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_template	Failure	128.31	test_templates.py
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py
test_06_download_detached_volume	Failure	137.52	test_volumes.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	1510.50	test_host_maintenance.py

[borisstoyanov]

@somejfn can you please verify this on your setup?

[PaulAngus]

LGTM
Tested with cloud.physical_network_isolation_methods.isolation_method set to 'VLAN', 'vlan' and 'Vlan'.
Shared network created without issue.

[borisstoyanov]

LGTM, manually tested it, smoketests also look good.

[somejfn]

Fix is confirmed. I can create a new network now based on the shared network offering