Prevent error on GroupAnswers on VR creation by nvazquez · Pull Request #3018 · apache/cloudstack

nvazquez · 2018-11-09T18:36:20Z

Description

On VR creation it has been noticed that management server receives these answers:

{ Ans: , MgmtId: 7206518937063, via: 11, Ver: v1, Flags: 10, [{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success: Creating file in VR, with ip: 169.254.3.212, file: vm_password.json.2b0e06a0-821f-41f1-bf8f-b9805f490a6c","null - success: Error: inet prefix is expected rather than \"table\".\nError: inet address is expected rather than \"table\".\n"],"result":true,"wait":0}},{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success: Creating file in VR, with ip: 169.254.3.212, file: vm_metadata.json.01da0832-2dd7-451b-a526-1de81d737a80","null - success: Error: inet prefix is expected rather than \"table\".\nError: inet address is expected rather than \"table\".\n"],"result":true,"wait":0}}] }

This has been originated by empty parameters on VR commands: (cloud.log)

2018-11-05 16:50:59,260  CsHelper.py execute:188 Executing: ip route show default via  table Table_eth0 proto static
Error: inet prefix is expected rather than "table"

2018-11-05 16:50:59,269  CsHelper.py execute:188 Executing: ip route add default via  table Table_eth0 proto static
Error: inet address is expected rather than "table"

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

Deploy VM on Isolated or Shared network - VR created

rafaelweingartner · 2018-11-09T18:39:55Z

-        cmd = "throw %s table %s proto static" % (address, table)
-        self.set_route(cmd)
+
+        if not table or not address:


By your changes, I am assuming that it is ok if we do not receive a routing table to be configured.
Do you know in which cases this situation might happen?

We could detect it each time we deploy a VR on 4.11.2 RC4

PaulAngus · 2018-11-09T20:02:24Z

@blueorangutan package

blueorangutan · 2018-11-09T20:03:07Z

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-11-09T20:31:59Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2417

PaulAngus · 2018-11-10T08:44:10Z

@blueorangutan test matrix

blueorangutan · 2018-11-10T08:45:09Z

@PaulAngus a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

PaulAngus · 2018-11-10T09:22:15Z

@blueorangutan test matrix

blueorangutan · 2018-11-10T09:23:09Z

@PaulAngus a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2018-11-10T16:15:25Z

Trillian test result (tid-3156)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23175 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3018-t3156-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Error`	13.28	test_scale_vm.py

blueorangutan · 2018-11-10T16:38:35Z

Trillian test result (tid-3157)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24455 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3018-t3157-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_10_destroy_cpvm	`Failure`	48.26	test_ssvm.py
test_05_rvpc_multi_tiers	`Failure`	319.96	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	342.71	test_vpc_redundant.py

yadvr

Lgtm, we should probably find and fix the issue of None typed key saved as None string in one of the merge.py databag scripts. I'm okay with the change.

PaulAngus · 2018-11-12T09:32:38Z

smoketests generally look ok, but i'm manually checking the VPC failures.

DaanHoogland · 2018-11-12T12:21:14Z


                # add 'defaul via gateway' rule in the device specific routing table
-                if "gateway" in self.address and self.address["gateway"] != "None":
+                if "gateway" in self.address and self.address["gateway"] and self.address["gateway"] != "None":


isn't there a '!= None` missing in this expression? (x != None and x != "None") just paranoia, i guess

Why do we check here on "None" as a String? And not None as you should in Python?

I think because somewhere the python None is stringyfied and gets in the way, @wido

PaulAngus · 2018-11-12T13:24:48Z

test was re-run with no issues. so LGTM. will now merge.

blueorangutan · 2018-11-12T22:41:44Z

Trillian test result (tid-3168)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45361 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3018-t3168-vmware-65.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_00_deploy_vm_root_resize	`Failure`	502.54	test_deploy_vm_root_resize.py

Adição de tamanho de cadeia de _backup_ para ofertas nativas de _backup_ Closes #3018 See merge request scclouds/scclouds!1311

Prevent error on GroupAnswers on VR creation

dea0b3e

nvazquez requested review from DaanHoogland, PaulAngus, rafaelweingartner and yadvr November 9, 2018 18:37

rafaelweingartner reviewed Nov 9, 2018

View reviewed changes

yadvr approved these changes Nov 11, 2018

View reviewed changes

yadvr added this to the 4.11.2.0 milestone Nov 12, 2018

yadvr added type:bug component:virtual-router labels Nov 12, 2018

yadvr requested review from GabrielBrascher and wido November 12, 2018 06:11

DaanHoogland reviewed Nov 12, 2018

View reviewed changes

PaulAngus merged commit f95aec4 into apache:4.11 Nov 12, 2018

nvazquez deleted the fixrouterfilecreation branch April 6, 2020 14:43

winterhazel pushed a commit that referenced this pull request Jan 28, 2026

Merge branch 'chain-size-granularity' into '4.20.0.0-scclouds'

117e6eb

Adição de tamanho de cadeia de _backup_ para ofertas nativas de _backup_ Closes #3018 See merge request scclouds/scclouds!1311

Conversation

nvazquez commented Nov 9, 2018

Description

Types of changes

How Has This Been Tested?

Uh oh!

rafaelweingartner Nov 9, 2018

Choose a reason for hiding this comment

Uh oh!

nvazquez Nov 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PaulAngus commented Nov 9, 2018

Uh oh!

blueorangutan commented Nov 9, 2018

Uh oh!

blueorangutan commented Nov 9, 2018

Uh oh!

PaulAngus commented Nov 10, 2018

Uh oh!

blueorangutan commented Nov 10, 2018

Uh oh!

PaulAngus commented Nov 10, 2018

Uh oh!

blueorangutan commented Nov 10, 2018

Uh oh!

blueorangutan commented Nov 10, 2018

Uh oh!

blueorangutan commented Nov 10, 2018

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

PaulAngus commented Nov 12, 2018

Uh oh!

DaanHoogland Nov 12, 2018

Choose a reason for hiding this comment

Uh oh!

wido Nov 12, 2018

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Nov 12, 2018

Choose a reason for hiding this comment

Uh oh!

PaulAngus commented Nov 12, 2018

Uh oh!

blueorangutan commented Nov 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nvazquez Nov 9, 2018 •

edited

Loading