Allow users of all types to create L2 networks by dhlaluku · Pull Request #3158 · apache/cloudstack

dhlaluku · 2019-01-30T11:56:28Z

Description

Allow users of all types to create L2 guest networks

Also fixes #3081

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

API

How Has This Been Tested?

dhlaluku · 2019-01-30T14:08:49Z

@bluorangutan package

dhlaluku · 2019-01-30T14:10:17Z

@borisstoyanov @PaulAngus @nvazquez @GabrielBrascher @wido please review

yadvr

@dhlaluku can you reply/address Rafale's comment, and also check if this may allow normal users to create a L2 network with a custom vlan/vni ID? You can test this by creating a L2 network offering that allows specification of VLAN ID. /cc @nvazquez

yadvr · 2019-01-30T16:11:51Z

Left some comments, otherwise LGTM.

yadvr · 2019-01-30T16:12:05Z

@blueorangutan package

blueorangutan · 2019-01-30T16:12:14Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

PaulAngus · 2019-01-30T16:24:36Z

@rhtyd i tested the feature in its 'previous form' offerings which allowed the operator to specify a VLAN were not visible to a 'user' only and 'admin'.
@dhlaluku can confirm.

yadvr · 2019-01-30T16:25:47Z

Thanks @PaulAngus LGTM based on your remark.

yadvr

LGTM based on Paul's remark

blueorangutan · 2019-01-30T16:35:36Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2582

yadvr · 2019-01-30T16:46:24Z

@blueorangutan test

blueorangutan · 2019-01-30T16:47:13Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

dhlaluku · 2019-01-30T18:07:35Z

@rhtyd the VLAN ID API request parameter is only available for the Admin, not available for any other user on both API and UI.

blueorangutan · 2019-01-31T00:11:49Z

Trillian test result (tid-3361)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24942 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3158-t3361-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 66 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.79	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.14	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.26	test_primary_storage.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.19	test_snapshots.py
test_11_migrate_vm	`Error`	18.10	test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration	`Error`	81.53	test_vm_life_cycle.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Failure`	0.14	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	2.38	test_host_maintenance.py

dhlaluku · 2019-01-31T04:53:38Z

@blueorangutan test

blueorangutan · 2019-01-31T08:14:48Z

@dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov

LGTM, tested it manually, lets wait for latests smoketests

blueorangutan · 2019-02-01T19:13:10Z

Trillian test result (tid-3366)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28893 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3158-t3366-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 66 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.86	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.13	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.24	test_primary_storage.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.23	test_snapshots.py
test_11_migrate_vm	`Error`	19.28	test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration	`Error`	62.70	test_vm_life_cycle.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Failure`	0.12	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	2.35	test_host_maintenance.py

GabrielBrascher · 2019-02-01T20:10:28Z

@blueorangutan package

blueorangutan · 2019-02-01T20:11:22Z

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

dhlaluku · 2019-02-06T13:45:20Z

@rhtyd sure, let me set it against 4.11

dhlaluku · 2019-02-07T09:53:36Z

@rhtyd rebased against 4.11.
@blueorangutan package

blueorangutan · 2019-02-07T09:53:47Z

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-02-07T10:13:33Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2600

DaanHoogland · 2019-03-20T17:55:18Z

@blueorangutan test

blueorangutan · 2019-03-20T17:55:33Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-03-21T00:59:16Z

Trillian test result (tid-3428)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23307 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3158-t3428-kvm-centos7.zip
Smoke tests completed. 68 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

dhlaluku · 2019-03-21T11:17:21Z

@blueorangutan package

blueorangutan · 2019-03-21T11:17:35Z

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-03-21T11:36:46Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2637

Allow users of all types to create L2 guest networks. Fixes apache#3081

Correção na criação de _snapshots_ incrementais Closes #3158 See merge request scclouds/scclouds!1323

dhlaluku changed the title ~~Allow users of all types to create L2 networks~~ [WIP] Allow users of all types to create L2 networks Jan 30, 2019

GabrielBrascher assigned dhlaluku Jan 30, 2019

GabrielBrascher added the component:UI label Jan 30, 2019

dhlaluku changed the title ~~[WIP] Allow users of all types to create L2 networks~~ Allow users of all types to create L2 networks Jan 30, 2019

GabrielBrascher requested review from PaulAngus, nvazquez, rafaelweingartner, wido and yadvr January 30, 2019 15:40

rafaelweingartner reviewed Jan 30, 2019

View reviewed changes

Comment thread server/src/main/java/com/cloud/network/NetworkServiceImpl.java Outdated

yadvr reviewed Jan 30, 2019

View reviewed changes

yadvr approved these changes Jan 30, 2019

View reviewed changes

borisstoyanov approved these changes Feb 1, 2019

View reviewed changes

dhlaluku closed this Feb 6, 2019

dhlaluku reopened this Feb 6, 2019

GabrielBrascher modified the milestones: 4.12.0.0, 5.0.0.0 Feb 6, 2019

dhlaluku force-pushed the support-L2-networks-for-users branch from 8c199e9 to cdc693b Compare February 7, 2019 09:50

dhlaluku changed the base branch from master to 4.11 February 7, 2019 09:52

dhlaluku closed this Mar 13, 2019

dhlaluku reopened this Mar 13, 2019

dhlaluku force-pushed the support-L2-networks-for-users branch 2 times, most recently from 21f824e to 40cc6f1 Compare March 21, 2019 10:46

dhlaluku changed the base branch from 4.11 to master March 21, 2019 10:46

Allow users to create L2 network types

f54461a

dhlaluku force-pushed the support-L2-networks-for-users branch from 40cc6f1 to f54461a Compare March 21, 2019 11:16

dhlaluku changed the base branch from master to 4.11 March 21, 2019 11:16

yadvr modified the milestones: 4.13.0.0, 4.11.3.0 Mar 25, 2019

yadvr merged commit 55fb1c4 into apache:4.11 Mar 25, 2019

pbankonier pushed a commit to pbankonier/cloudstack that referenced this pull request Apr 24, 2019

server: Allow users to create L2 network types (apache#3158)

2c165db

Allow users of all types to create L2 guest networks. Fixes apache#3081

weizhouapache mentioned this pull request Dec 22, 2021

network: fix vm can be deployed on L2 network of other accounts #5784

Merged

12 tasks

winterhazel pushed a commit that referenced this pull request Jan 28, 2026

Merge branch 'fix-lock-snapshot' into '4.20.0.0-scclouds'

3b71ec8

Correção na criação de _snapshots_ incrementais Closes #3158 See merge request scclouds/scclouds!1323

Conversation

dhlaluku commented Jan 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

dhlaluku commented Jan 30, 2019

Uh oh!

dhlaluku commented Jan 30, 2019

Uh oh!

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jan 30, 2019

Uh oh!

yadvr commented Jan 30, 2019

Uh oh!

blueorangutan commented Jan 30, 2019

Uh oh!

PaulAngus commented Jan 30, 2019

Uh oh!

yadvr commented Jan 30, 2019

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 30, 2019

Uh oh!

yadvr commented Jan 30, 2019

Uh oh!

blueorangutan commented Jan 30, 2019

Uh oh!

dhlaluku commented Jan 30, 2019

Uh oh!

blueorangutan commented Jan 31, 2019

Uh oh!

dhlaluku commented Jan 31, 2019

Uh oh!

blueorangutan commented Jan 31, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Feb 1, 2019

Uh oh!

GabrielBrascher commented Feb 1, 2019

Uh oh!

blueorangutan commented Feb 1, 2019

Uh oh!

dhlaluku commented Feb 6, 2019

Uh oh!

dhlaluku commented Feb 7, 2019

Uh oh!

blueorangutan commented Feb 7, 2019

Uh oh!

blueorangutan commented Feb 7, 2019

Uh oh!

DaanHoogland commented Mar 20, 2019

Uh oh!

blueorangutan commented Mar 20, 2019

Uh oh!

blueorangutan commented Mar 21, 2019

Uh oh!

dhlaluku commented Mar 21, 2019

Uh oh!

blueorangutan commented Mar 21, 2019

Uh oh!

blueorangutan commented Mar 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dhlaluku commented Jan 30, 2019 •

edited

Loading