Skip to content

packaging: systemctl daemon-reload after agent install or upgrade#3269

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:agent-reload-systemctl
Apr 9, 2019
Merged

packaging: systemctl daemon-reload after agent install or upgrade#3269
yadvr merged 1 commit into
apache:4.11from
shapeblue:agent-reload-systemctl

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Apr 8, 2019

This runs systemctl daemon-reload after cloudstack-agent is installed
or upgraded. This fixes a warning seen in el7 environments which asks
admin to perform daemon-reload after agent is installed or upgraded.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This runs systemctl daemon-reload after cloudstack-agent is installed
or upgraded.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Apr 8, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2687

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Apr 8, 2019

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Copy Markdown
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3483)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25749 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3269-t3483-kvm-centos7.zip
Smoke tests completed. 68 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, upgraded management and agent, then restarted with no such error prompted

@yadvr yadvr merged commit 96611fc into apache:4.11 Apr 9, 2019
pbankonier pushed a commit to pbankonier/cloudstack that referenced this pull request Apr 24, 2019
…ache#3269)

This runs systemctl daemon-reload after cloudstack-agent is installed
or upgraded.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
nvazquez pushed a commit to shapeblue/cloudstack that referenced this pull request Jul 24, 2019
…ache#3269)

This runs systemctl daemon-reload after cloudstack-agent is installed
or upgraded.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 96611fc)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants